Add Malta Postal Code and Phone Number #975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
profnandaa
reviewed
Apr 10, 2019
profnandaa
added
the
🧹 needs-update
profnandaa
reviewed
Apr 19, 2019
| @@ -3775,6 +3775,18 @@ describe('Validators', () => { | |||
| '123456789', | |||
| '+254800723845', | |||
| ], | |||
| },{ | |||
| locale: 'en-mt', | |||
There was a problem hiding this comment.
should be en-MT (check case).
| @@ -38,6 +38,7 @@ const patterns = { | |||
| LU: fourDigit, | |||
| LV: /^LV\-\d{4}$/, | |||
| MX: fiveDigit, | |||
| MT: /^[A-Za-z]{3}\s{0,1}\d{4}$/, | |||
There was a problem hiding this comment.
Also add tests for isPostalCode
profnandaa
added a commit
to profnandaa/validator.js
that referenced
this pull request
Jul 2, 2019
profnandaa
added a commit
to profnandaa/validator.js
that referenced
this pull request
Jul 2, 2019
- clean-up merge conflicts - add tests for postal code, ref: https://en.wikipedia.org/wiki/Postal_codes_in_Malta
Merged
|
@fgnm -- merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've add Malta Postal Code (XXX0000 or XXX 0000) and Phone Number (+356XXYYYYYY). Can you please merge this as soon as possibile? It's very critical for my, many many thanks :)