Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#990. Fix for Fiji mobile phones format validation. #991

Closed
wants to merge 1 commit into from
Closed

#990. Fix for Fiji mobile phones format validation. #991

wants to merge 1 commit into from

Conversation

luckyluck
Copy link

No description provided.

profnandaa
profnandaa reviewed Apr 10, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR 👍

Can you please add tests and update the README?

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Apr 10, 2019
@ezkemboi ezkemboi mentioned this pull request Jun 29, 2019
Merged
profnandaa pushed a commit that referenced this pull request Jul 1, 2019
@ezkemboi @profnandaa
#990. Clean up PR #991 (#1052)
f3f4070 
* #990. Fix for Fiji mobile phones format validation.

* chore: tests and update readme for Fiji isMobile fix

closes #991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa left review comments

Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luckyluck @profnandaa