Support generateProjectDependencyGraph in SubProject #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#125 will be achieved by this merge request as well. |
|
@tedliang can you show an before and after image of your repository? |
tedliang
force-pushed
the
supportProjectDependencyGraphInSubProject
branch
from
e54e844 to
b3c4157
Compare
|
|
|
@tedliang thanks! Do you mind adding a test for this new behavior? Then we can merge |
tedliang
commented
Sep 26, 2021
| @@ -213,7 +216,7 @@ class DependencyGraphGeneratorPluginTest { | |||
| .withPluginClasspath() | |||
| .withGradleVersion("5.0") | |||
| .withProjectDir(testProjectDir.root) | |||
| .withArguments("generateDependencyGraph", "generateProjectDependencyGraph") | |||
| .withArguments("generateDependencyGraph", "generateProjectDependencyGraph", "app:generateProjectDependencyGraph") | |||
There was a problem hiding this comment.
This will trigger the task to generate project dependency graph on sub project app.
tedliang
commented
Sep 26, 2021
| // We don't want to assert the content of the image, just that it exists. | ||
| assertThat(File(testProjectDir.root, "app/build/reports/project-dependency-graph/project-dependency-graph.svg")).exists() | ||
|
|
||
| assertThat(File(testProjectDir.root, "app/build/reports/project-dependency-graph/project-dependency-graph.dot")).hasContent(projectDependencyGraph("app")) |
There was a problem hiding this comment.
This will make sure the graph generated from sub project app is correct. If you rollback the implementation code, this test will be failed, as the original code didn't include the nested dependencies.
|
@tedliang thank you very much. If you want to continue working on this project - I have very little time to do PRs - please do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In monorepo, generateProjectDependencyGraph from individual sub project would be more practical.
eg.
./gradlew app:generateProjectDependencyGraph