-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MavenCentral badge. #18
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=========================================
Coverage 87.08% 87.08%
Complexity 48 48
=========================================
Files 12 12
Lines 271 271
Branches 39 39
=========================================
Hits 236 236
Misses 30 30
Partials 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does the latestVersion variable come from? Also what about the SNAPSHOT versions?
@vanniktech The If you publish the SNAPSHOT version on MavenCentral you could add another badge and maybe change above variable name from |
We could do the badge but I don't mind maintaining the latest version. I do it in all my repos and changing it in every repo is quite a lot of work. |
It is of course totally up to you to decide if you want to maintain the version string in the |
If you remove the last version change I'm happy to merge. |
@vanniktech I updated my pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
No description provided.