Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MavenCentral badge. #18

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Add MavenCentral badge. #18

merged 1 commit into from
Mar 12, 2018

Conversation

johnjohndoe
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 12, 2018

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage     87.08%   87.08%           
  Complexity       48       48           
=========================================
  Files            12       12           
  Lines           271      271           
  Branches         39       39           
=========================================
  Hits            236      236           
  Misses           30       30           
  Partials          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e3da1...774edcd. Read the comment docs.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the latestVersion variable come from? Also what about the SNAPSHOT versions?

@johnjohndoe
Copy link
Contributor Author

@vanniktech The latestVersion variable can be defined by the user - a common pattern is to maintain all version strings in the root level build.gradle file. Here it is meant as a placeholder to remind users to pick the desired version.

If you publish the SNAPSHOT version on MavenCentral you could add another badge and maybe change above variable name from latestVersion to latestReleaseVersion. Than you can use latestSnapshotVersion for the SNAPSHOT code snippet.

@vanniktech
Copy link
Owner

We could do the badge but I don't mind maintaining the latest version. I do it in all my repos and changing it in every repo is quite a lot of work.

@johnjohndoe
Copy link
Contributor Author

It is of course totally up to you to decide if you want to maintain the version string in the README.md. In my experience it is just another location where one forgets to update when a new release is shipped. Feel free to decide on you own.

@vanniktech
Copy link
Owner

If you remove the last version change I'm happy to merge.

@johnjohndoe johnjohndoe changed the title Add MavenCentral badge. Avoid to maintain latest version in README.md. Add MavenCentral badge. Mar 12, 2018
@johnjohndoe
Copy link
Contributor Author

@vanniktech I updated my pull request.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vanniktech vanniktech merged commit c7784c7 into vanniktech:master Mar 12, 2018
@johnjohndoe johnjohndoe deleted the patch-1 branch March 12, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants