Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the project build.gradle file as an input #89

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Conversation

vanniktech
Copy link
Owner

Fixes #86

@vanniktech
Copy link
Owner Author

Can you please test it out @bjorndarri ?

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #89 into master will decrease coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     59.39%   58.54%   -0.85%     
+ Complexity       38       36       -2     
============================================
  Files             7        7              
  Lines           197      193       -4     
  Branches         38       38              
============================================
- Hits            117      113       -4     
  Misses           75       75              
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
.../graph/generator/DependencyGraphGeneratorPlugin.kt 66.66% <ø> (-2.57%) 6 <0> (ø)
...cy/graph/generator/DependencyGraphGeneratorTask.kt 37.5% <ø> (-6.95%) 3 <0> (-1)
...h/generator/ProjectDependencyGraphGeneratorTask.kt 37.5% <ø> (-6.95%) 3 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869044b...fc50295. Read the comment docs.

@bjorndarri
Copy link

I'm afraid this does not fix the problem. I tried the nuclear option by simply commenting out the inputFile variable in DependencyGraphGeneratorTask and ProjectDependencyGraphGeneratorTask (and all references to it) and that fixed the problem, that is, I can generate graphs for my little test project as well as the original project which prompted this issue. All tests pass except the Android ones since I don't have the SDK set up and the detektCheck task failed, but I don't really know what that is all about.

So, it looks like the inputFile variable is not used anywhere, could it be removed?

@vanniktech
Copy link
Owner Author

Can you write a failing test? The inputFile variable is used to update the state of the task and to support incremental compilation.

@vanniktech vanniktech changed the title Handle non present build.gradle file correctly. Remove the project build.gradle file as an input Apr 30, 2019
@vanniktech vanniktech merged commit cfd2862 into master Apr 30, 2019
@vanniktech vanniktech deleted the empty branch April 30, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle missing build.gradle file
2 participants