Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service account json support added and README updated #9

Merged
merged 16 commits into from
Oct 23, 2023

Conversation

chibombo
Copy link
Member

## What's new

  • Service account JSON support
  • README updated
  • Github builds the repository

Details

Firebase deprecated the TOKEN implementation and the README contained the instruction for the deprecated implementation. This PR updates:

  • Google URLs
  • The user can use the deprecated implementation but we need to generate the FirebaseSDK private key manually in the Firebase Console
  • Github Actions builds the project in the latest Ubuntu version available. PRs trigger it.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +1 to +8
//
// FernoConfiguration.swift
// Ferno
//
// Created by Maxim Krouk on 6/12/20.
//

import Vapor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//
// FernoConfiguration.swift
// Ferno
//
// Created by Maxim Krouk on 6/12/20.
//
import Vapor
import Vapor

@0xTim 0xTim merged commit 626e661 into vapor-community:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants