Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to see if changing the timestamps will improve display duration accuracy in the rAF time version.
We were using the timestamp
ts
that is automatically passed to rAF callbacks, but this timestamp is the time that the frame's main thread starts. Instead, I'm wondering if it would help to get a performance.now() timestamp inside the callback function. See here under 'Addendum about the rAF timestamp', and in the 'Life of a frame' figures, I think this is the difference between 'Begin frame' and 'rAF'.I think the timing of the frame's main thread might be more consistent over time/frames, so I'm still using the automatically-passed
ts
timestamps to determine the frame durations.If this looks an improvement then I can change the time + frames version as well.