-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gum.Kni #167
Gum.Kni #167
Conversation
ToolsUtilities/FileManager.cs
Outdated
catch | ||
{ | ||
// WASM ? | ||
return "./"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AppContext.BaseDirectory throws in WASM, and I changed ExeLocation to "./".
I am not sure if that is the correct fix here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's okay, unless we can get a proper #if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it was Path.GetDirectoryName() that was failing.
Now I skip it when the value is "/", and let the rest of the method to do, whatever it does.
This also fixed the issue we had with /Content/Content/ path!
MonoGameGum/KniGum.csproj
Outdated
</PropertyGroup> | ||
|
||
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'"> | ||
<DefineConstants>$(DefineConstants);MONOGAME;KNI;USE_GUMCOMMON</DefineConstants> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I define both MONOGAME and KNI. Perhaps it's best to define only KNI and expand all
#if MONOGAME
to
#if MONOGAME || KNI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya I think that's probably best, even though it's more work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
f8c7e68
to
542719f
Compare
@@ -422,21 +422,24 @@ private void PopulateElementSavesFromReferences(string projectRootDirectory, Lin | |||
} | |||
} | |||
|
|||
foreach(var reference in BehaviorReferences) | |||
if (BehaviorReferences != null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried rooting the Gum assemblies from the main project, and setting IsTrimmable on the libraries.
That seems to be XmlSerializer behavior.
when project set PublishAot True, empty BehaviorReferences is serialized as null.
No description provided.