Fix docker build error (benchmark-job, loadtest)

[vankichi]

Description

SSIA

Related Issue

Versions

• Vald Version: v1.7.16
• Go Version: v1.23.5
• Rust Version: v1.83.0
• Docker Version: v27.4.0
• Kubernetes Version: v1.32.0
• Helm Version: v3.16.3
• NGT Version: v2.3.5
• Faiss Version: v1.9.0

Checklist

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer

Summary by CodeRabbit

• Dependency Management
  • Removed libhdf5-dev package from multiple Dockerfiles across different project environments
  • Updated Makefile to include ldconfig after HDF5 installation to refresh dynamic linker cache

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request involves modifications to multiple Dockerfiles and a Makefile related to HDF5 library dependencies. The changes consistently remove the libhdf5-dev package from various Docker images used in different contexts such as CI, development, client, benchmark, and CLI loadtest environments. Additionally, the Makefile's hdf5/install target is updated to include ldconfig after installation, which refreshes the dynamic linker cache. These changes suggest a systematic removal or modification of HDF5 library handling across the project's build and development infrastructure.

Changes

File	Change Summary
Makefile.d/tools.mk	Added ldconfig to hdf5/install target to update dynamic linker cache
dockers/*/Dockerfile	Removed libhdf5-dev package from installation list in multiple Docker images: - CI base image - Development image - Example client image - Benchmark job image - CLI loadtest image

Possibly related PRs

• [CI] Add workflow to synchronize ubuntu base image #2526: Modifications to Dockerfiles related to HDF5 library
• Bugfix vald-helm-operator build error #2610: Changes to Makefile.d/docker.mk affecting build process and dependencies
• Fix typo for docker.mk #2720: Modifications to Makefile.d/docker.mk with HDF5-related build arguments

Suggested labels

size/M

Suggested reviewers

• kpango

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[cloudflare-workers-and-pages]

Deploying vald with    Cloudflare Pages

Latest commit:	19d4ccc
Status:	✅  Deploy successful!
Preview URL:	https://a1d1bd82.vald.pages.dev
Branch Preview URL:	https://bugfix-docker-fix-benchmark.vald.pages.dev

View logs

[vankichi]

@coderabbitai please review

[coderabbitai]

@vankichi I've reviewed the changes. The modifications look good and properly address the Docker build errors by:

1. Removing redundant libhdf5-dev package installations since HDF5 is being built from source
2. Adding ldconfig after HDF5 installation to ensure proper shared library cache updates
3. Consistently applying these changes across all affected Dockerfiles

The changes are well-structured and should resolve the build issues for benchmark-job and loadtest components.

🔗 Analysis chain

---

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Get PR details and changes
gh pr view 2819 --json files,commits

Length of output: 1621

---

Script:

#!/bin/bash
# Get the diff of the changes
gh pr diff 2819

# Also get the content of the modified files for better context
for file in Makefile.d/tools.mk dockers/ci/base/Dockerfile dockers/dev/Dockerfile dockers/example/client/Dockerfile dockers/tools/benchmark/job/Dockerfile dockers/tools/cli/loadtest/Dockerfile hack/docker/gen/main.go; do
  echo "=== $file ==="
  cat "$file" 2>/dev/null || echo "File not found"
  echo
done

Length of output: 72451

✅ Actions performed

Comments resolved and changes approved.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Makefile.d/tools.mk (1)

262-263: LGTM! The addition of ldconfig is essential for proper library registration.

The addition of ldconfig after HDF5 installation is crucial as it updates the dynamic linker cache, ensuring that the newly installed HDF5 libraries are properly registered in the system. This change complements the removal of libhdf5-dev package from Dockerfiles and follows best practices for installing libraries from source.

This change helps prevent potential library loading issues during runtime by ensuring that the dynamic linker can locate the HDF5 libraries correctly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3865d4 and 19d4ccc.

⛔ Files ignored due to path filters (1)

• hack/docker/gen/main.go is excluded by !**/gen/**

📒 Files selected for processing (6)

• Makefile.d/tools.mk (1 hunks)
• dockers/ci/base/Dockerfile (0 hunks)
• dockers/dev/Dockerfile (0 hunks)
• dockers/example/client/Dockerfile (0 hunks)
• dockers/tools/benchmark/job/Dockerfile (0 hunks)
• dockers/tools/cli/loadtest/Dockerfile (0 hunks)

💤 Files with no reviewable changes (5)

• dockers/tools/benchmark/job/Dockerfile
• dockers/example/client/Dockerfile
• dockers/dev/Dockerfile
• dockers/ci/base/Dockerfile
• dockers/tools/cli/loadtest/Dockerfile

[kpango]

LGTM