Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(honeycomb sink): Support compression #21889

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

hgiasac
Copy link
Contributor

@hgiasac hgiasac commented Nov 26, 2024

Summary

Support compression for the Honeycomb sink. The zstd format is enabled by default.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Create a Honeycomb API key and configure compression for vector:

sources:
  docker_logs:
    type: docker_logs
    include_labels:
      - vector.enable=true
sinks:
  honeycomb:
    inputs:
      - component: docker_logs
    type: honeycomb
    api_key: xxx
    dataset: dataset-dev
    compression: gzip

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: external docs Anything related to Vector's external, public documentation labels Nov 26, 2024
@hgiasac hgiasac marked this pull request as ready for review November 26, 2024 07:27
@hgiasac hgiasac requested review from a team as code owners November 26, 2024 07:27
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hgiasac

@pront pront enabled auto-merge November 26, 2024 15:21
auto-merge was automatically disabled November 26, 2024 16:06

Head branch was pushed to by a user without write access

@pront pront enabled auto-merge November 26, 2024 16:08
@pront pront added this pull request to the merge queue Nov 26, 2024
@jhgilbert jhgilbert self-assigned this Nov 26, 2024
Merged via the queue into vectordotdev:master with commit 58a4055 Nov 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants