Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): use rustflags instead of rustc wrappers #5559

Merged
merged 2 commits into from
Dec 16, 2020
Merged

chore(ci): use rustflags instead of rustc wrappers #5559

merged 2 commits into from
Dec 16, 2020

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Dec 16, 2020

now that

  • the aarch64-musl cross image respects the rustflags setting specified in .cargo/config, and
  • rustc 1.48 supports the -C link-self-contained flag

we can remove the rustc wrappers in favor of rustflags settings in .cargo/config

@japaric japaric force-pushed the remove-rustc-wrappers branch from 99bf74b to 3c05cc2 Compare December 16, 2020 15:37
@jamtur01 jamtur01 added domain: ci Anything related to Vector's CI environment domain: platforms Anything related to Vector's supported platforms labels Dec 16, 2020
@Hoverbear
Copy link
Contributor

I'm fairly sure the check failure is unrelated.

@jszwedko
Copy link
Member

Yeah, the feature check should be fixed by #5553

@jamtur01 jamtur01 merged commit c7da80a into vectordotdev:master Dec 16, 2020
binarylogic pushed a commit that referenced this pull request Dec 17, 2020
@japaric @binarylogic
chore(ci): use rustflags instead of rustc wrappers (#5559)
3dd4332 
* ci: use rustflags instead of rustc wrappers

Signed-off-by: Jorge Aparicio <[email protected]>

* remove the wrapper scripts

Signed-off-by: Jorge Aparicio <[email protected]>
@jamtur01 jamtur01 self-assigned this Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear Hoverbear approved these changes

@jamtur01 jamtur01 Awaiting requested review from jamtur01

Assignees

@jamtur01 jamtur01

Labels
domain: ci Anything related to Vector's CI environment domain: platforms Anything related to Vector's supported platforms
Projects
None yet
Milestone
2020-12-07: Nanite Repair System
Development

Successfully merging this pull request may close these issues.
4 participants
@japaric @Hoverbear @jszwedko @jamtur01