fix(typing): Resolve multiple @utils.use_signature issues

[dangotbanned]

Description

This PR addresses problems with this decorator that cause the wrong arguments to bind in some cases.

I've tried (and failed) to fix this multiple times over the past 1-2 months, but until now, hadn't come up with a solution that:

• fixed all of the cases
• satisfied both mypy and pyright

After one signature fails in a chain of methods - an IDE (not ipython) can't understand much that follows.

Therefore, I consider the issue quite signficant.

Tasks

• Handle methods & functions correctly in use_signature (53057b7)
• Add a repro for all the call sites this fixes
• Update use_signature return type
  • pyright is inferring Overload[...], which isn't a form I've seen before
  • Overload[(cb: (T@decorate, ...) -> R@decorate, /) -> ((T@decorate, **P@use_signature) -> R@decorate), (cb: (...) -> R@decorate, /) -> ((**P@use_signature) -> R@decorate)]
  • Whatever the solution is, will most likely be a comment
  • Inserted into docstring to avoid breakage
• Fix bug w/ Concatenate[T, ...] inside TypeAliasType on < (3, 11)
  • typing.Concatenate for 3.10
  • typing_extensions.Concatenate for 3.8, 3.9

Repro

from typing_extensions import reveal_type
import altair as alt

# Would also include the function equivalent(s),
# if they did not already have `# pyright: ignore`(s)
concat = alt.ConcatChart()
hconcat = alt.HConcatChart()
vconcat = alt.VConcatChart()
layer = alt.LayerChart()

conf_facet = alt.Chart().configure_facet()
conf_concat = alt.Chart().configure_concat()
conf_tooltip_format = alt.Chart().configure_tooltipFormat()
conf_view = alt.Chart().configure_view()

reveal_type(conf_facet)
reveal_type(conf_concat)
reveal_type(conf_tooltip_format)
reveal_type(conf_view)

chained = conf_facet.configure_arc()
reveal_type(chained)

Warnings on main

Fixed on fix-use-signature-2

Examples that fail type checking on main

• https://github.com/vega/altair/blob/5b5877903bce55392c66d9dd08b21e0da58a5fda/tests/examples_methods_syntax/ridgeline_plot.py
• https://github.com/vega/altair/blob/5b5877903bce55392c66d9dd08b21e0da58a5fda/tests/examples_methods_syntax/us_population_over_time.py
• https://github.com/vega/altair/blob/5b5877903bce55392c66d9dd08b21e0da58a5fda/tests/examples_methods_syntax/airport_connections.py

Screenshots

Issues in api.py

I added these ignore comments in response to this issue during 72bd84d

altair/altair/vegalite/v5/api.py

Line 4168 in 5b58779

return ConcatChart(concat=charts, **kwargs) # pyright: ignore

altair/altair/vegalite/v5/api.py

Line 4272 in 5b58779

return HConcatChart(hconcat=charts, **kwargs) # pyright: ignore

altair/altair/vegalite/v5/api.py

Line 4378 in 5b58779

return VConcatChart(vconcat=charts, **kwargs) # pyright: ignore

altair/altair/vegalite/v5/api.py

Line 4504 in 5b58779

return LayerChart(layer=charts, **kwargs) # pyright: ignore

Enabling type checking for tests/

[binste]

Nice! A lot for me to learn here. I've added some questions where I could use your help so I can review this further.

[dangotbanned]

Nice! A lot for me to learn here. I've added some questions where I could use your help so I can review this further.

Thanks for the review @binste!

Tried my best to answer everything so far.
This was definitely quite a complex one to solve, so I'm happy to explain more if you have any other questions.

[binste]

Thanks again for digging through it! :)

[dangotbanned]

Thanks again for digging through it! :)

No problem, thanks for taking the time to review @binste