fix : returning error instead of *gqlError.Error #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
#99
Background
gqlparser functions are returning
nil
but the return type is*gqlrrror.Error.
This is how the code looks like before my change: https://github.com/vektah/gqlparser/blob/master/parser/schema.go#L9
The problem is while using this code,
err != nil
doesn't work sinceerr
is actually not nil it is zero value*gqlerror.Error
.The issue had been raised in the past: #99 and they also had a PR for fix #100 which then was closed by author themself.