-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bottom links in postgres examples clickable #866
Open
nsylv
wants to merge
8
commits into
vercel:main
Choose a base branch
from
nsylv:make-links-clickable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsylv
requested review from
okbel,
lfades,
goncy,
dominiksipowicz,
leerob and
lpalmes
as code owners
February 7, 2024 03:52
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@nsylv is attempting to deploy a commit to the Vercel Examples Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the nav items on the bottom of the postgres examples clickable
To repro, check out the example demo (seen here) and try to click on one of the links (e.g. "Prisma"). Note: the window needs to be short enough that these nav items are in line with the footer
What These Changes Do
Before these links were showing up behind the footer, so this change sets their z-index to 10 in order to have them render on top
It also removes the
w-full
style so the opposite problem (e.g. the other example links covering the footer) does not happenOn mobile, there isn't overlap
Demo URL
Type of Change