Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: python3 bootstrap handler should be called only once #77

Merged
merged 2 commits into from
Jul 19, 2022
Merged

fix: python3 bootstrap handler should be called only once #77

merged 2 commits into from
Jul 19, 2022

Conversation

stkevintan
Copy link
Contributor

fix #56

@stkevintan
Copy link
Contributor Author

Hi, @styfle, could you help review this simple fix please? I believe most of the Windows users are blocked by this bug, thanks!

styfle
styfle approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

The repo is a little out of date because vercel dev usually calls startDevServer() instead of using this repo.

@styfle styfle requested a review from TooTallNate July 3, 2022 20:18
@stkevintan
Copy link
Contributor Author

Looks good, thanks!

The repo is a little out of date because vercel dev usually calls startDevServer() instead of using this repo.

I see, but as I checked the current bit, python runtime hasn't implemented the startDevServer interface yet. perhaps I can contribute later on.

@styfle
Copy link
Member

styfle commented Jul 6, 2022

Something is wrong with CI 🤔
I created another PR to investigate (#78)

@styfle styfle merged commit f060460 into vercel:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

For vercel dev, it said HTTP Error 500: Internal Server Error (python3)
2 participants
@stkevintan @styfle