Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix electron window.open vulnerability #3457

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Fix electron window.open vulnerability #3457

merged 2 commits into from
Feb 5, 2019

Conversation

chabou
Copy link
Contributor

@chabou chabou commented Feb 4, 2019

Apply suggested workaround: https://electronjs.org/blog/window-open-fix

@chabou chabou requested a review from juancampa February 4, 2019 17:33
@chabou chabou added the ❣️ Priority: High Issue is of High priority label Feb 4, 2019
@juancampa juancampa merged commit 17fcae5 into vercel:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancampa juancampa juancampa approved these changes

Assignees
No one assigned
Labels
❣️ Priority: High Issue is of High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chabou @juancampa