Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus terminal on closing search box #6230

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Focus terminal on closing search box #6230

merged 3 commits into from
Jan 10, 2022

Conversation

letsandeepio
Copy link
Contributor

This PR fixes the search box closing behaviour as focus is restored back to the respective terminal after the search box is closed.

@github-actions

This comment has been minimized.

Sign in to view
@LabhanshAgrawal
Copy link
Collaborator

Please rebase and push

@letsandeepio
Copy link
Contributor Author

Done 👍

@github-actions
Copy link

Hi there,
Thank you for contributing to Hyper!
You can get the build artifacts from here.
Here are screenshots of Hyper built from this pr.
Imgur ImagesImgur Images

@LabhanshAgrawal LabhanshAgrawal changed the title fix autofocus when search box is close Focus terminal on closing search box Jan 10, 2022
@LabhanshAgrawal LabhanshAgrawal merged commit 9f4687c into vercel:canary Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@letsandeepio @LabhanshAgrawal