(fix: #75439) Handle null or undefined href prop passed into componentt

vercel · Jan 29, 2025 · ff737c9 · ff737c9
1 parent c97dff9
commit ff737c9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/next/src/client/app-dir/link.tsx b/packages/next/src/client/app-dir/link.tsx
@@ -412,7 +412,7 @@ const Link = React.forwardRef<HTMLAnchorElement, LinkPropsReal>(
     let children: React.ReactNode
 
     const {
-      href: hrefProp,
+      href: unfilteredHrefProp,
       as: asProp,
       children: childrenProp,
       prefetch: prefetchProp = null,
@@ -427,6 +427,8 @@ const Link = React.forwardRef<HTMLAnchorElement, LinkPropsReal>(
       ...restProps
     } = props
 
+    const hrefProp = unfilteredHrefProp ?? ''
+
     children = childrenProp
 
     if (
@@ -582,7 +584,7 @@ const Link = React.forwardRef<HTMLAnchorElement, LinkPropsReal>(
     }
 
     const { href, as } = React.useMemo(() => {
-      const resolvedHref = formatStringOrUrl(hrefProp)
+      const resolvedHref = formatStringOrUrl(hrefProp ?? '')
       return {
         href: resolvedHref,
         as: asProp ? formatStringOrUrl(asProp) : resolvedHref,

diff --git a/packages/next/src/client/link.tsx b/packages/next/src/client/link.tsx
@@ -255,7 +255,7 @@ const Link = React.forwardRef<HTMLAnchorElement, LinkPropsReal>(
     let children: React.ReactNode
 
     const {
-      href: hrefProp,
+      href: unfilteredHrefProp,
       as: asProp,
       children: childrenProp,
       prefetch: prefetchProp = null,
@@ -271,6 +271,8 @@ const Link = React.forwardRef<HTMLAnchorElement, LinkPropsReal>(
       ...restProps
     } = props
 
+    const hrefProp = unfilteredHrefProp ?? ''
+
     children = childrenProp
 
     if (