Fix and add test filterModuleRules for next-plugin-storybook #17306

ja0n · 2020-09-23T09:57:40Z

I tried the preset provided at packages/next-plugin-storybook but it was raising error due to an unsafe negation in the preset.js file.

I added a test to show the error:

● next-plugin-storybook filterModuleRules › should filter module rules correctly

    TypeError: rule.test.test is not a function

      48 |       if (!rule.test instanceof RegExp) return true
      49 |       // use Next.js' built-in CSS
    > 50 |       if (rule.test.test('hello.css')) {
         |                     ^
      51 |         return false
      52 |       }
      53 |       // use next-babel-loader instead of storybook's babel-loader

      at filter (../packages/next-plugin-storybook/preset.js:50:21)
          at Array.filter (<anonymous>)
      at Object.filterModuleRules (../packages/next-plugin-storybook/preset.js:46:28)
      at Object.<anonymous> (unit/webpack-config-overrides.test.js:12:36)

ijjk · 2020-09-23T10:07:18Z

Stats from current PR

Default Server Mode

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	12.6s	12.4s	-193ms
nodeModulesSize	62.9 MB	62.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.329	2.432	⚠️ +0.1
/ avg req/sec	1073.62	1027.99	⚠️ -45.63
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.555	1.51	-0.04
/error-in-render avg req/sec	1607.4	1655.36	+47.96

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-772ea11..1d22.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-911f3f8..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	997 B	997 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	13.9s	13.6s	-327ms
nodeModulesSize	62.9 MB	62.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-772ea11..1d22.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-911f3f8..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: 8c61308

ijjk · 2020-09-23T10:10:17Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	12.6s	12.4s	-191ms
nodeModulesSize	62.9 MB	62.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.412	2.406	-0.01
/ avg req/sec	1036.66	1038.96	+2.3
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.461	1.419	-0.04
/error-in-render avg req/sec	1710.92	1761.63	+50.71

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-772ea11..1d22.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-911f3f8..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Rendered Page Sizes

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	997 B	997 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	14.3s	14.1s	-259ms
nodeModulesSize	62.9 MB	62.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..9339.js gzip	10.9 kB	10.9 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-772ea11..1d22.js gzip	7.16 kB	7.16 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	57.8 kB	57.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..dule.js gzip	6.77 kB	6.77 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-911f3f8..dule.js gzip	6.23 kB	6.23 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-d2344ce..8b36.js gzip	1.3 kB	1.3 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-f8c0daf..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	322 B	322 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	651 B	651 B	✓

Serverless bundles

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: f53eadf

ijjk · 2020-09-23T10:16:18Z

Failing test suites

Commit: 8c61308

test/unit/webpack-config-overrides.test.js

next-plugin-storybook filterModuleRules > should filter module rules correctly

Expand output

● next-plugin-storybook filterModuleRules › should filter module rules correctly

TypeError: rule.test.test is not a function

  48 |       if (!rule.test instanceof RegExp) return true
  49 |       // use Next.js' built-in CSS
> 50 |       if (rule.test.test('hello.css')) {
     |                     ^
  51 |         return false
  52 |       }
  53 |       // use next-babel-loader instead of storybook's babel-loader

  at filter (../packages/next-plugin-storybook/preset.js:50:21)
      at Array.filter (<anonymous>)
  at Object.filterModuleRules (../packages/next-plugin-storybook/preset.js:46:28)
  at Object.<anonymous> (unit/webpack-config-overrides.test.js:12:36)

eric-burel · 2020-12-18T08:03:39Z

@ja0n I kinda fixed it in #18367 too, I've noticed this bug immediately when switching to TS.

ja0n · 2020-12-27T15:35:17Z

@eric-burel if the regression test adds no value, you can close this. otherwise, I can check what's wrong with the pipeline

eric-burel · 2021-01-06T16:22:51Z

@ja0n I haven't managed to correctly build the package in TypeScript yet, so I think your PR is better for now, all the more that you tested it.
I need to get a better understanding of Next TS build and Webpack related features before getting back at this so it will take a long while.

timneutkens

Overall this looks fine, can you fix the merge conflict?

ja0n · 2021-01-26T13:03:49Z

@timneutkens seems like line 48 was already patched at this point, so this MR is only adding the regression test now. thanks

ijjk · 2021-01-26T13:12:58Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	10.3s	10.4s	⚠️ +96ms
nodeModulesSize	74.9 MB	74.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.053	2.058	0
/ avg req/sec	1217.47	1214.71	⚠️ -2.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.302	1.266	-0.04
/error-in-render avg req/sec	1920.7	1974.3	+53.6

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	12.5s	12.3s	-265ms
nodeModulesSize	74.9 MB	74.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	12.5s	12.6s	⚠️ +135ms
nodeModulesSize	74.9 MB	74.9 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.058	2.053	0
/ avg req/sec	1214.74	1217.53	+2.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.248	1.279	⚠️ +0.03
/error-in-render avg req/sec	2002.82	1954.04	⚠️ -48.78

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
index.html gzip	587 B	587 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "8NGboZX9rebl8eNfCvVLc",
+        "buildId": "AzCFXQvDzJKnxL1vsa0AU",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8NGboZX9rebl8eNfCvVLc/_buildManifest.js"
+      src="/_next/static/AzCFXQvDzJKnxL1vsa0AU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8NGboZX9rebl8eNfCvVLc/_ssgManifest.js"
+      src="/_next/static/AzCFXQvDzJKnxL1vsa0AU/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "8NGboZX9rebl8eNfCvVLc",
+        "buildId": "AzCFXQvDzJKnxL1vsa0AU",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8NGboZX9rebl8eNfCvVLc/_buildManifest.js"
+      src="/_next/static/AzCFXQvDzJKnxL1vsa0AU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8NGboZX9rebl8eNfCvVLc/_ssgManifest.js"
+      src="/_next/static/AzCFXQvDzJKnxL1vsa0AU/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "8NGboZX9rebl8eNfCvVLc",
+        "buildId": "AzCFXQvDzJKnxL1vsa0AU",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8NGboZX9rebl8eNfCvVLc/_buildManifest.js"
+      src="/_next/static/AzCFXQvDzJKnxL1vsa0AU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8NGboZX9rebl8eNfCvVLc/_ssgManifest.js"
+      src="/_next/static/AzCFXQvDzJKnxL1vsa0AU/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: bcb70fd

timneutkens

Thanks!

ijjk · 2021-01-26T19:18:05Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	10.9s	11.1s	⚠️ +222ms
nodeModulesSize	74.9 MB	74.9 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.252	2.367	⚠️ +0.12
/ avg req/sec	1110.1	1056.23	⚠️ -53.87
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.569	1.684	⚠️ +0.12
/error-in-render avg req/sec	1593.76	1484.34	⚠️ -109.42

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	13.2s	13.1s	-92ms
nodeModulesSize	74.9 MB	74.9 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
buildDuration	13.2s	13.6s	⚠️ +451ms
nodeModulesSize	74.9 MB	74.9 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.19	2.22	⚠️ +0.03
/ avg req/sec	1141.54	1126.11	⚠️ -15.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.721	1.577	-0.14
/error-in-render avg req/sec	1452.56	1585.47	+132.91

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	ja0n/next.js fix-storybook-plugin	Change
index.html gzip	587 B	587 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "M8ucVj6qDs0Q9HS3zAlEY",
+        "buildId": "nUla2md9_GllU2ERhOu6D",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M8ucVj6qDs0Q9HS3zAlEY/_buildManifest.js"
+      src="/_next/static/nUla2md9_GllU2ERhOu6D/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M8ucVj6qDs0Q9HS3zAlEY/_ssgManifest.js"
+      src="/_next/static/nUla2md9_GllU2ERhOu6D/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "M8ucVj6qDs0Q9HS3zAlEY",
+        "buildId": "nUla2md9_GllU2ERhOu6D",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M8ucVj6qDs0Q9HS3zAlEY/_buildManifest.js"
+      src="/_next/static/nUla2md9_GllU2ERhOu6D/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M8ucVj6qDs0Q9HS3zAlEY/_ssgManifest.js"
+      src="/_next/static/nUla2md9_GllU2ERhOu6D/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "M8ucVj6qDs0Q9HS3zAlEY",
+        "buildId": "nUla2md9_GllU2ERhOu6D",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M8ucVj6qDs0Q9HS3zAlEY/_buildManifest.js"
+      src="/_next/static/nUla2md9_GllU2ERhOu6D/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M8ucVj6qDs0Q9HS3zAlEY/_ssgManifest.js"
+      src="/_next/static/nUla2md9_GllU2ERhOu6D/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 0ba5c15

ja0n requested review from ijjk, lfades, Timer and timneutkens as code owners September 23, 2020 09:57

ja0n changed the title ~~add test filterModuleRules for next-plugin-storybook~~ Fix and add test filterModuleRules for next-plugin-storybook Oct 19, 2020

timneutkens requested changes Jan 23, 2021

View reviewed changes

add test filterModuleRules for next-plugin-storybook

bcb70fd

ja0n force-pushed the fix-storybook-plugin branch from f53eadf to bcb70fd Compare January 26, 2021 13:01

timneutkens approved these changes Jan 26, 2021

View reviewed changes

Merge branch 'canary' into fix-storybook-plugin

0ba5c15

kodiakhq bot merged commit e1fe28c into vercel:canary Jan 26, 2021

ja0n deleted the fix-storybook-plugin branch January 27, 2021 02:19

snyk-bot mentioned this pull request Dec 16, 2021

[Snyk] Fix for 3 vulnerabilities lethu96/next.js#28

Open

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix and add test filterModuleRules for next-plugin-storybook #17306

Fix and add test filterModuleRules for next-plugin-storybook #17306

ja0n commented Sep 23, 2020

ijjk commented Sep 23, 2020

ijjk commented Sep 23, 2020

ijjk commented Sep 23, 2020

eric-burel commented Dec 18, 2020

ja0n commented Dec 27, 2020

eric-burel commented Jan 6, 2021

timneutkens left a comment

ja0n commented Jan 26, 2021

ijjk commented Jan 26, 2021

Diffs

timneutkens left a comment

ijjk commented Jan 26, 2021

Diffs

Fix and add test filterModuleRules for next-plugin-storybook #17306

Fix and add test filterModuleRules for next-plugin-storybook #17306

Conversation

ja0n commented Sep 23, 2020

ijjk commented Sep 23, 2020

Stats from current PR

ijjk commented Sep 23, 2020

Stats from current PR

ijjk commented Sep 23, 2020

Failing test suites

eric-burel commented Dec 18, 2020

ja0n commented Dec 27, 2020

eric-burel commented Jan 6, 2021

timneutkens left a comment

Choose a reason for hiding this comment

ja0n commented Jan 26, 2021

ijjk commented Jan 26, 2021

Stats from current PR

Diffs

timneutkens left a comment

Choose a reason for hiding this comment

ijjk commented Jan 26, 2021

Stats from current PR

Diffs