Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "nonce" from <Head> to the injected <style> to satisfy CSP #19150

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Add "nonce" from <Head> to the injected <style> to satisfy CSP #19150

merged 6 commits into from
Nov 13, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 13, 2020

Fixes #18557

@ijjk
Copy link
Member

ijjk commented Nov 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
buildDuration 14.7s 14.3s -448ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +766 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js 18557-style-nonce Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.659 2.649 -0.01
/ avg req/sec 940.05 943.69 +3.64
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.744 1.728 -0.02
/error-in-render avg req/sec 1433.35 1447.08 +13.73
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b0b971f..64a5.js gzip 6.5 kB 6.53 kB ⚠️ +30 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ⚠️ +30 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-22cb0cf..dule.js gzip 5.61 kB 5.64 kB ⚠️ +33 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ⚠️ +33 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 18557-style-nonce Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary vercel/next.js 18557-style-nonce Change
index.html gzip 971 B 969 B -2 B
link.html gzip 978 B 975 B -3 B
withRouter.html gzip 965 B 963 B -2 B
Overall change 2.91 kB 2.91 kB -7 B

Diffs

Diff for main-288e71c..7e8ff798f.js 
@@ -1068,6 +1068,9 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
               return tag.getAttribute("data-n-href");
             })
           );
+          var noscript = document.querySelector("noscript[data-n-css]");
+          var nonce =
+            noscript == null ? void 0 : noscript.getAttribute("data-n-css");
           styleSheets.forEach(function(_ref7) {
             var href = _ref7.href,
               text = _ref7.text;
@@ -1076,6 +1079,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
               var styleTag = document.createElement("style");
               styleTag.setAttribute("data-n-href", href);
               styleTag.setAttribute("media", "x");
+
+              if (nonce) {
+                styleTag.setAttribute("nonce", nonce);
+              }
+
               document.head.appendChild(styleTag);
               styleTag.appendChild(document.createTextNode(text));
             }
Diff for main-b5494d9..2e.module.js 
@@ -779,6 +779,9 @@
           var currentHrefs = new Set(
             currentStyleTags.map(tag => tag.getAttribute("data-n-href"))
           );
+          var noscript = document.querySelector("noscript[data-n-css]");
+          var nonce =
+            noscript == null ? void 0 : noscript.getAttribute("data-n-css");
           styleSheets.forEach(_ref5 => {
             var { href, text } = _ref5;
 
@@ -786,6 +789,11 @@
               var styleTag = document.createElement("style");
               styleTag.setAttribute("data-n-href", href);
               styleTag.setAttribute("media", "x");
+
+              if (nonce) {
+                styleTag.setAttribute("nonce", nonce);
+              }
+
               document.head.appendChild(styleTag);
               styleTag.appendChild(document.createTextNode(text));
             }
Diff for index.html 
@@ -4,10 +4,10 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
-    <noscript data-n-css="true"></noscript>
+    <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      href="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-288e71cf56f7e8ff798f.js"
+      src="/_next/static/chunks/main-d150ac684e24a32f68f6.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      src="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -4,10 +4,10 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
-    <noscript data-n-css="true"></noscript>
+    <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      href="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-288e71cf56f7e8ff798f.js"
+      src="/_next/static/chunks/main-d150ac684e24a32f68f6.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      src="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -4,10 +4,10 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
-    <noscript data-n-css="true"></noscript>
+    <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      href="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-288e71cf56f7e8ff798f.js"
+      src="/_next/static/chunks/main-d150ac684e24a32f68f6.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      src="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
buildDuration 15.8s 16.3s ⚠️ +489ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +766 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b0b971f..64a5.js gzip 6.5 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-65ddebf..18f3.js gzip N/A 6.53 kB N/A
Overall change 58.9 kB 58.9 kB ⚠️ +30 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-22cb0cf..dule.js gzip 5.61 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-52e4325..dule.js gzip N/A 5.64 kB N/A
Overall change 53.6 kB 53.6 kB ⚠️ +33 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 18557-style-nonce Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_error.js 916 kB 916 kB ⚠️ +95 B
404.html 4.61 kB 4.61 kB -4 B
hooks.html 3.86 kB 3.86 kB -4 B
index.js 916 kB 916 kB ⚠️ +95 B
link.js 974 kB 975 kB ⚠️ +95 B
routerDirect.js 967 kB 967 kB ⚠️ +95 B
withRouter.js 967 kB 967 kB ⚠️ +95 B
Overall change 4.75 MB 4.75 MB ⚠️ +467 B
Commit: 151ee99

@ijjk

This comment has been minimized.

Sign in to view
@vercel vercel bot temporarily deployed to Preview November 13, 2020 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview November 13, 2020 18:43 Inactive
@vercel vercel bot temporarily deployed to Preview November 13, 2020 18:46 Inactive
@styfle styfle changed the title Add support for style nonce Add "nonce" from <Head> to inject <style> Nov 13, 2020
@styfle styfle changed the title Add "nonce" from <Head> to inject <style> Add "nonce" from <Head> to the injected <style> to satisfy CSP Nov 13, 2020
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@vercel vercel bot temporarily deployed to Preview November 13, 2020 19:25 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
buildDuration 12.7s 12.8s ⚠️ +101ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +766 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js 18557-style-nonce Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.447 2.368 -0.08
/ avg req/sec 1021.76 1055.59 +33.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.344 1.293 -0.05
/error-in-render avg req/sec 1859.72 1933.44 +73.72
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b0b971f..64a5.js gzip 6.5 kB 6.53 kB ⚠️ +30 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ⚠️ +30 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-22cb0cf..dule.js gzip 5.61 kB 5.64 kB ⚠️ +33 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.6 kB 53.6 kB ⚠️ +33 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 18557-style-nonce Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary vercel/next.js 18557-style-nonce Change
index.html gzip 971 B 969 B -2 B
link.html gzip 978 B 975 B -3 B
withRouter.html gzip 965 B 963 B -2 B
Overall change 2.91 kB 2.91 kB -7 B

Diffs

Diff for main-288e71c..7e8ff798f.js 
@@ -1068,6 +1068,9 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
               return tag.getAttribute("data-n-href");
             })
           );
+          var noscript = document.querySelector("noscript[data-n-css]");
+          var nonce =
+            noscript == null ? void 0 : noscript.getAttribute("data-n-css");
           styleSheets.forEach(function(_ref7) {
             var href = _ref7.href,
               text = _ref7.text;
@@ -1076,6 +1079,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
               var styleTag = document.createElement("style");
               styleTag.setAttribute("data-n-href", href);
               styleTag.setAttribute("media", "x");
+
+              if (nonce) {
+                styleTag.setAttribute("nonce", nonce);
+              }
+
               document.head.appendChild(styleTag);
               styleTag.appendChild(document.createTextNode(text));
             }
Diff for main-b5494d9..2e.module.js 
@@ -779,6 +779,9 @@
           var currentHrefs = new Set(
             currentStyleTags.map(tag => tag.getAttribute("data-n-href"))
           );
+          var noscript = document.querySelector("noscript[data-n-css]");
+          var nonce =
+            noscript == null ? void 0 : noscript.getAttribute("data-n-css");
           styleSheets.forEach(_ref5 => {
             var { href, text } = _ref5;
 
@@ -786,6 +789,11 @@
               var styleTag = document.createElement("style");
               styleTag.setAttribute("data-n-href", href);
               styleTag.setAttribute("media", "x");
+
+              if (nonce) {
+                styleTag.setAttribute("nonce", nonce);
+              }
+
               document.head.appendChild(styleTag);
               styleTag.appendChild(document.createTextNode(text));
             }
Diff for index.html 
@@ -4,10 +4,10 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
-    <noscript data-n-css="true"></noscript>
+    <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      href="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-288e71cf56f7e8ff798f.js"
+      src="/_next/static/chunks/main-d150ac684e24a32f68f6.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      src="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -4,10 +4,10 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
-    <noscript data-n-css="true"></noscript>
+    <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      href="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-288e71cf56f7e8ff798f.js"
+      src="/_next/static/chunks/main-d150ac684e24a32f68f6.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      src="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -4,10 +4,10 @@
     <meta charset="utf-8" />
     <meta name="viewport" content="width=device-width" />
     <meta name="next-head-count" content="2" />
-    <noscript data-n-css="true"></noscript>
+    <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      href="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-288e71cf56f7e8ff798f.js"
+      src="/_next/static/chunks/main-d150ac684e24a32f68f6.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-b5494d90160de3f12c2e.module.js"
+      src="/_next/static/chunks/main-3b7e144d19b69d756b5c.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
buildDuration 14.5s 14.8s ⚠️ +215ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +766 B
Client Bundles (main, webpack, commons) Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b0b971f..64a5.js gzip 6.5 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-65ddebf..18f3.js gzip N/A 6.53 kB N/A
Overall change 58.9 kB 58.9 kB ⚠️ +30 B
Client Bundles (main, webpack, commons) Modern Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-22cb0cf..dule.js gzip 5.61 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-52e4325..dule.js gzip N/A 5.64 kB N/A
Overall change 53.6 kB 53.6 kB ⚠️ +33 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 18557-style-nonce Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary vercel/next.js 18557-style-nonce Change
_error.js 916 kB 916 kB ⚠️ +95 B
404.html 4.61 kB 4.61 kB -4 B
hooks.html 3.86 kB 3.86 kB -4 B
index.js 916 kB 916 kB ⚠️ +95 B
link.js 974 kB 975 kB ⚠️ +95 B
routerDirect.js 967 kB 967 kB ⚠️ +95 B
withRouter.js 967 kB 967 kB ⚠️ +95 B
Overall change 4.75 MB 4.75 MB ⚠️ +467 B
Commit: 38df9f3

@styfle styfle marked this pull request as ready for review November 13, 2020 19:47
@kodiakhq kodiakhq bot merged commit 318a1bf into canary Nov 13, 2020
@kodiakhq kodiakhq bot deleted the 18557-style-nonce branch November 13, 2020 20:29
@ranyehushua ranyehushua mentioned this pull request Jan 15, 2021
Closed
@ericbiewener ericbiewener mentioned this pull request Apr 2, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline styles in Next 10 don't work with strict Content-Security-Policy
3 participants
@styfle @ijjk @Timer