Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't swallow MODULE_NOT_FOUND error #24577

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Don't swallow MODULE_NOT_FOUND error #24577

merged 2 commits into from
Apr 30, 2021

Conversation

PepijnSenders
Copy link
Contributor

@PepijnSenders PepijnSenders commented Apr 28, 2021 •
edited
Loading

Bug

  • Related issues linked using fixes #24328
  • Integration tests added

The change in #24328 will swallow any MODULE_NOT_FOUND errors triggered in the page. If you for example have a page with a broken import, it will tell you Error: Failed to load /whatever. This of course doesn't really tell people what is going on internally (a broken import). I added a check to see if the error actually happened in the page.

@PepijnSenders PepijnSenders mentioned this pull request Apr 28, 2021
Merged
2 tasks
@ijjk
Copy link
Member

ijjk commented Apr 28, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
buildDuration 16.2s 16.1s -83ms
buildDurationCached 5.4s 5s -432ms
nodeModulesSize 46.7 MB 46.7 MB -552 B
Page Load Tests Overall increase ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.816 2.858 ⚠️ +0.04
/ avg req/sec 887.84 874.7 ⚠️ -13.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.706 1.579 -0.13
/error-in-render avg req/sec 1465.18 1583.11 +117.93
Client Bundles (main, webpack, commons)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.11 kB 7.11 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
buildDuration 20.4s 20.4s -39ms
buildDurationCached 7.5s 7.5s -27ms
nodeModulesSize 46.7 MB 46.7 MB -552 B
Client Bundles (main, webpack, commons)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.11 kB 7.11 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_error.js 1.39 MB 1.39 MB -134 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB -134 B
link.js 1.45 MB 1.45 MB -134 B
routerDirect.js 1.44 MB 1.44 MB -134 B
withRouter.js 1.44 MB 1.44 MB -134 B
Overall change 7.14 MB 7.14 MB -670 B
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
buildDuration 13.7s 13.6s -99ms
buildDurationCached 5.8s 5.8s ⚠️ +78ms
nodeModulesSize 46.7 MB 46.7 MB -552 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.803 2.84 ⚠️ +0.04
/ avg req/sec 891.87 880.4 ⚠️ -11.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.711 1.724 ⚠️ +0.01
/error-in-render avg req/sec 1461.39 1450.29 ⚠️ -11.1
Client Bundles (main, webpack, commons)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.18 kB 7.18 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: bf8253c

@ijjk
Copy link
Member

ijjk commented Apr 30, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
buildDuration 14.4s 14.5s ⚠️ +136ms
buildDurationCached 4.7s 4.3s -361ms
nodeModulesSize 46.6 MB 46.6 MB -552 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.53 2.531 0
/ avg req/sec 988.25 987.84 ⚠️ -0.41
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.448 1.564 ⚠️ +0.12
/error-in-render avg req/sec 1726.99 1598.14 ⚠️ -128.85
Client Bundles (main, webpack, commons)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
index.html gzip 611 B 611 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
buildDuration 18s 17.6s -387ms
buildDurationCached 6.5s 6.6s ⚠️ +38ms
nodeModulesSize 46.6 MB 46.6 MB -552 B
Client Bundles (main, webpack, commons)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_error.js 1.35 MB 1.35 MB -134 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.35 MB 1.35 MB -134 B
link.js 1.4 MB 1.4 MB -134 B
routerDirect.js 1.4 MB 1.4 MB -134 B
withRouter.js 1.4 MB 1.4 MB -134 B
Overall change 6.91 MB 6.91 MB -670 B
Webpack 4 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
buildDuration 12.1s 12s -9ms
buildDurationCached 5s 4.9s -135ms
nodeModulesSize 46.6 MB 46.6 MB -552 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.467 2.54 ⚠️ +0.07
/ avg req/sec 1013.36 984.42 ⚠️ -28.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.484 1.473 -0.01
/error-in-render avg req/sec 1684.59 1697.38 +12.79
Client Bundles (main, webpack, commons)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary PepijnSenders/next.js feature/dont-swallow-module-not-found-error Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: a36891b

@kodiakhq kodiakhq bot merged commit d5de1c5 into vercel:canary Apr 30, 2021
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@PepijnSenders
Don't swallow MODULE_NOT_FOUND error (vercel#24577)
3ef8a67 
## Bug

- [x] Related issues linked using [`fixes vercel#24328`](vercel#24328 (comment))
- [ ] Integration tests added

The change in vercel#24328 will swallow any `MODULE_NOT_FOUND` errors triggered in the page. If you for example have a page with a broken import, it will tell you `Error: Failed to load /whatever`. This of course doesn't really tell people what is going on internally (a broken import). I added a check to see if the error actually happened in the page.
@jaga810 jaga810 mentioned this pull request Jun 3, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PepijnSenders @ijjk