Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rewrite shape in Storybook #24827

Merged
merged 2 commits into from
May 6, 2021
Merged

Fix rewrite shape in Storybook #24827

merged 2 commits into from
May 6, 2021

Conversation

eric-burel
Copy link
Contributor

@eric-burel eric-burel commented May 5, 2021 •
edited
Loading

This fixes a bug in @next/plugin-storybook caused by an update in the rewrite structure, solution was provided by @stefanprobst #19345 (comment)

Secondary question: it would be awesome if someone at Next could help translating preset.js into TypeScript, this would catch those bugs immediately. I've tried in #18367 but failed to build correctly.

Bug

@eric-burel eric-burel mentioned this pull request May 5, 2021
Closed
7 tasks
@ijjk

This comment has been minimized.

Sign in to view
ijjk
ijjk approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We can look at updating this to typescript in another PR, it looks like you'll need to merge canary manually on this PR before it can be landed since changes from contributors is disabled.

@eric-burel
Copy link
Contributor Author

Done for the update, is that something I miconfigured for the contributors changes disabled?

@ijjk
Copy link
Member

ijjk commented May 6, 2021

It usually defaults to allow contributors to update although when creating a PR with a fork in an GitHub org this can be disabled by default, related GitHub doc

@ijjk
Copy link
Member

ijjk commented May 6, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
buildDuration 14.3s 14.2s -85ms
buildDurationCached 4.9s 4.3s -580ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.454 2.41 -0.04
/ avg req/sec 1018.79 1037.37 +18.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.539 1.393 -0.15
/error-in-render avg req/sec 1624.92 1794.74 +169.82
Client Bundles (main, webpack, commons)
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.05 kB 3.05 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.52 kB 8.52 kB ✓
Client Build Manifests
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
_buildManifest.js gzip 394 B 394 B ✓
Overall change 394 B 394 B ✓
Rendered Page Sizes
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
index.html gzip 560 B 560 B ✓
link.html gzip 569 B 569 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode
General
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
buildDuration 17.6s 17.6s -25ms
buildDurationCached 6.4s 6.4s ⚠️ +26ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.05 kB 3.05 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.52 kB 8.52 kB ✓
Client Build Manifests
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
_buildManifest.js gzip 394 B 394 B ✓
Overall change 394 B 394 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
_error.js 1.34 MB 1.34 MB ⚠️ +2 B
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.35 MB 1.35 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB ✓
Overall change 6.9 MB 6.9 MB ⚠️ +2 B
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
buildDuration 12.1s 12s -112ms
buildDurationCached 4.9s 4.9s -14ms
nodeModulesSize 46.6 MB 46.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.471 2.512 ⚠️ +0.04
/ avg req/sec 1011.55 995.21 ⚠️ -16.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.382 1.462 ⚠️ +0.08
/error-in-render avg req/sec 1809.1 1709.9 ⚠️ -99.2
Client Bundles (main, webpack, commons)
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.72 kB 3.72 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.37 kB 9.37 kB ✓
Client Build Manifests
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary lbke/next.js bugfix/plugin-storybook-rewrite-shape Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 2e23d3c

@kodiakhq kodiakhq bot merged commit 796c021 into vercel:canary May 6, 2021
@eric-burel eric-burel deleted the bugfix/plugin-storybook-rewrite-shape branch May 6, 2021 19:56
@eric-burel
Copy link
Contributor Author

eric-burel commented May 6, 2021 •
edited
Loading

I didn't find how to disable that for all PR as a default, only per PR, but I'll try to remember for future PR, thanks!

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@eric-burel
Fix rewrite shape in Storybook (vercel#24827)
f3e5bb7 
This fixes a bug in `@next/plugin-storybook` caused by an update in the rewrite structure, solution was provided by @stefanprobst vercel#19345 (comment)

Secondary question: it would be awesome if someone at Next could help translating `preset.js` into TypeScript, this would catch those bugs immediately. I've tried in vercel#18367 but failed to build correctly.

## Bug

- [X] Related issues linked using `fixes #number` => parent issue is an umbrella of various small issues: vercel#19345
- [X] Integration tests added => reproduction is implemented in https://github.com/lbke/next-plugin-storybook-demo until the package is more stable
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eric-burel @ijjk