Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the text for eslint/no-page-custom-font rule #25117

Merged
merged 6 commits into from
May 19, 2021
Merged

Update the text for eslint/no-page-custom-font rule #25117

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
640fc7b
Update the text for eslint/no-page-custom-font rule.
rgabs May 13, 2021
f2153e6
Merge branch 'canary' into eslint/no-page-custom-font-text-update
rgabs May 13, 2021
0e101e6
Merge branch 'canary' into eslint/no-page-custom-font-text-update
rgabs May 14, 2021
9fac5c3
Merge branch 'canary' into eslint/no-page-custom-font-text-update
rgabs May 14, 2021
b7b0012
Merge branch 'canary' into eslint/no-page-custom-font-text-update
ijjk May 19, 2021
db1e9c5
Merge branch 'canary' into eslint/no-page-custom-font-text-update
ijjk May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-plugin-next/lib/rules/no-page-custom-font.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ module.exports = {
context.report({
node,
message:
'Custom fonts should be added at the document level. See https://nextjs.org/docs/messages/no-page-custom-font.',
'Custom fonts not added at the document level will only load for a single page. This is discouraged. See https://nextjs.org/docs/messages/no-page-custom-font.',
})
}
},
Expand Down
4 changes: 2 additions & 2 deletions test/eslint-plugin-next/no-page-custom-font.unit.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ ruleTester.run('no-page-custom-font', rule, {
errors: [
{
message:
'Custom fonts should be added at the document level. See https://nextjs.org/docs/messages/no-page-custom-font.',
'Custom fonts not added at the document level will only load for a single page. This is discouraged. See https://nextjs.org/docs/messages/no-page-custom-font.',
type: 'JSXOpeningElement',
},
],
Expand Down Expand Up @@ -94,7 +94,7 @@ ruleTester.run('no-page-custom-font', rule, {
errors: [
{
message:
'Custom fonts should be added at the document level. See https://nextjs.org/docs/messages/no-page-custom-font.',
'Custom fonts not added at the document level will only load for a single page. This is discouraged. See https://nextjs.org/docs/messages/no-page-custom-font.',
type: 'JSXOpeningElement',
},
],
Expand Down