-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom Babel loader to avoid using separate Babel copies for loader and loader options #4417
Conversation
Thank you for helping pave the path for next.js' babel setup @loganfsmyth! Is there a defined pattern you'd want next.js users to do when we have some additional changes to how babel and webpack are used? |
@rgbkrk I think it depends on what your goal is for the additional changes. If you want to be able to add additional plugins and such, I'd personally say it would be up to Next to expose a
However, since your changes seem more focused on your specific usecase of compiling a specific set of |
That seems like a really smart idea so that it remains consistent like this PR.
I'd love to ask you more questions in the nteract monorepo if it's alright so I don't end up derailing your PR within next.js. As long as you've got the cycles, I'd love to figure out an ideal setup since I'm also transitioning us to babel 7 right now. Really happy to outline what we're doing and ensure we help others with monorepo + next + custom babel. It's ok if not, I'm sure you're plenty busy with lots of projects. |
@rgbkrk No problem, happy to try to answer any questions you have over there. Babel's Slack is also public if chat would be easier for quick back-and-forth discussions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this solution 👍 Thanks @loganfsmyth 😌
Apparently we didn't have a test for compiling with a custom |
Thank you very much @loganfsmyth 🙌 |
…er and loader options (vercel#4417) This resolves the > .value is not a valid Plugin property error showing up for people in vercel#4227 cc @timneutkens
…er and loader options (vercel#4417) This resolves the > .value is not a valid Plugin property error showing up for people in vercel#4227 cc @timneutkens
This resolves the
error showing up for people in #4227
cc @timneutkens