Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: replaced GTM component with GA in Google Analytics example #73597

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

suu3
Copy link
Contributor

@suu3 suu3 commented Dec 6, 2024

What?

Replaced the GoogleTagManager component with GoogleAnalytics in the with-google-analytics example.

Why?

The current implementation does not align with the docs, and a separate GTM example already exists.

How?

Replaced the GoogleTagManager component with GoogleAnalytics.

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 6, 2024
@ijjk
Copy link
Member

ijjk commented Dec 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: c3432c2

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@suu3 suu3 force-pushed the with-google-analytics branch from 3280ba1 to c3432c2 Compare December 10, 2024 00:04
@suu3
Copy link
Contributor Author

suu3 commented Dec 10, 2024

@samcx Hello, would you mind reviewing this PR if you have a moment?

@samcx samcx self-requested a review December 10, 2024 06:42
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) December 10, 2024 06:43
@samcx samcx merged commit 6284d41 into vercel:canary Dec 10, 2024
39 checks passed
@suu3
Copy link
Contributor Author

suu3 commented Dec 10, 2024

Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants