chore: do not change beforeSend when undefined (#84)

vercel · Nov 7, 2024 · b5d2980 · b5d2980
1 parent 857f881
commit b5d2980
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/web/src/react/index.test.tsx b/packages/web/src/react/index.test.tsx
@@ -60,5 +60,18 @@ describe('<SpeedInsights />', () => {
       expect(window.siq?.[0]).toEqual(['beforeSend', beforeSend2]);
       expect(window.siq).toHaveLength(1);
     });
+
+    it('does not change beforeSend when undefined', () => {
+      const beforeSend: Required<SpeedInsightsProps>['beforeSend'] = (event) =>
+        event;
+      const { rerender } = render(<SpeedInsights beforeSend={beforeSend} />);
+
+      expect(window.siq?.[0]).toEqual(['beforeSend', beforeSend]);
+      expect(window.siq).toHaveLength(1);
+      window.siq?.splice(0, 1);
+
+      rerender(<SpeedInsights />);
+      expect(window.siq).toHaveLength(0);
+    });
   });
 });
diff --git a/packages/web/src/react/index.tsx b/packages/web/src/react/index.tsx
@@ -9,7 +9,9 @@ export function SpeedInsights(
   },
 ): JSX.Element | null {
   useEffect(() => {
-    window.si?.('beforeSend', props.beforeSend);
+    if (props.beforeSend) {
+      window.si?.('beforeSend', props.beforeSend);
+    }
   }, [props.beforeSend]);
 
   const setScriptRoute = useRef<((path: string) => void) | null>(null);