[DOCS] Friendly spellcheck #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jastor11 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
This reworks our Node.js rendering logic to allow for: * passing binary request bodies in and out of Node.js: API routes can accept request bodies in POST, and can reply with any content type. * content source results that are recomputed every time: we don't want API routes to be cached (at least not by turbopack for now). It also reworks the `END_OF_OPERATION` logic to avoid hard coding a single end of operation marker (they're now unique per pool), and allow multiple kinds of operation events (`Step`, `Success`, `Error`). This is not a particularly good implementation for this. A better implementation would proxy the request from the client to the Node.js server in a more direct manner. We also need a way to tell turbo tasks "don't bother ever caching this", as right now every single API request and result will still be cached, even if we know they will never be used again. Finally, we should communicate with Node.js processes via a better mechanism than stdout. I made some progress on a prototype for using https://github.com/servo/ipc-channel with NAPI a while back, which I'd like to pick up some time after conf. However, it seems to work well enough for now, so yay. Co-authored-by: Tobias Koppers <[email protected]>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This reworks our Node.js rendering logic to allow for: * passing binary request bodies in and out of Node.js: API routes can accept request bodies in POST, and can reply with any content type. * content source results that are recomputed every time: we don't want API routes to be cached (at least not by turbopack for now). It also reworks the `END_OF_OPERATION` logic to avoid hard coding a single end of operation marker (they're now unique per pool), and allow multiple kinds of operation events (`Step`, `Success`, `Error`). This is not a particularly good implementation for this. A better implementation would proxy the request from the client to the Node.js server in a more direct manner. We also need a way to tell turbo tasks "don't bother ever caching this", as right now every single API request and result will still be cached, even if we know they will never be used again. Finally, we should communicate with Node.js processes via a better mechanism than stdout. I made some progress on a prototype for using https://github.com/servo/ipc-channel with NAPI a while back, which I'd like to pick up some time after conf. However, it seems to work well enough for now, so yay. Co-authored-by: Tobias Koppers <[email protected]>
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This reworks our Node.js rendering logic to allow for: * passing binary request bodies in and out of Node.js: API routes can accept request bodies in POST, and can reply with any content type. * content source results that are recomputed every time: we don't want API routes to be cached (at least not by turbopack for now). It also reworks the `END_OF_OPERATION` logic to avoid hard coding a single end of operation marker (they're now unique per pool), and allow multiple kinds of operation events (`Step`, `Success`, `Error`). This is not a particularly good implementation for this. A better implementation would proxy the request from the client to the Node.js server in a more direct manner. We also need a way to tell turbo tasks "don't bother ever caching this", as right now every single API request and result will still be cached, even if we know they will never be used again. Finally, we should communicate with Node.js processes via a better mechanism than stdout. I made some progress on a prototype for using https://github.com/servo/ipc-channel with NAPI a while back, which I'd like to pick up some time after conf. However, it seems to work well enough for now, so yay. Co-authored-by: Tobias Koppers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.