Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(action): pin nextest #6461

Merged
merged 1 commit into from
Nov 16, 2023
Merged

ci(action): pin nextest #6461

merged 1 commit into from
Nov 16, 2023

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Nov 15, 2023 •
edited
Loading

Closes PACK-1969

CI was failing to run turbopack tests with obscure error message

binding) ignoring invalid dependency `turbopack-tests` which is missing a lib target
error: error parsing Cargo metadata

Caused by:
  failed to construct package graph: for package 'preset_env_base 0.4.6 (registry+https://github.com/rust-lang/crates.io-index)': no dependencies found matching 'browserslist'

Tried a bunch of bisect, and finally able to figure out the dependency chain

  • cargo-nextest releases a new version, which was a culprit of above bug
  • install-action silently installs new version
  • CI started to fail all of sudden without any repo / user level code changes

Cargo's executable won't update unless explicitly specified, so this was not reproducible locally with currently installed version.

Mainly this is a side effect of cargo doesn't support dev deps executable (ref: rust-lang/cargo#2267). I tried to workaround via 3rd party pkg cargo-run-bin (https://github.com/dustinblackman/cargo-run-bin) but unfortunately it doesn't support Windows so it's not an easy option to adapt.

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 10:19pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 16, 2023 10:19pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@kwonoj kwonoj force-pushed the build-test branch 9 times, most recently from 7c8bc30 to 38f58ff Compare November 15, 2023 19:51
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 7e8d77c

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.92ms ± 0.87ms 21.84ms ± 0.83ms -0.34%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.33ms ± 0.84ms 21.30ms ± 0.84ms -0.13%
bench_startup/Turbopack CSR/1000 modules 1168.62ms ± 5.66ms 1173.00ms ± 22.03ms +0.37%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@kwonoj kwonoj force-pushed the build-test branch 2 times, most recently from e490049 to 16c6b89 Compare November 15, 2023 21:16
@kwonoj kwonoj force-pushed the build-test branch 3 times, most recently from c7dbc5b to b149a60 Compare November 15, 2023 21:49
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 1e571fa

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.83ms ± 0.79ms 21.79ms ± 0.87ms -0.15%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.49ms ± 0.83ms 21.23ms ± 0.84ms -1.20%
bench_startup/Turbopack CSR/1000 modules 1159.00ms ± 7.67ms 1150.73ms ± 21.17ms -0.71%

@kwonoj kwonoj force-pushed the build-test branch 17 times, most recently from 6c2dc43 to 4486138 Compare November 16, 2023 22:15
@kwonoj kwonoj changed the title [TEST] [DONOTMERGE] ci(action): pin nextest Nov 16, 2023
@kwonoj kwonoj marked this pull request as ready for review November 16, 2023 22:42
@kwonoj kwonoj requested review from a team as code owners November 16, 2023 22:42
@kwonoj kwonoj merged commit 5ac790b into main Nov 16, 2023
50 of 51 checks passed
@kwonoj kwonoj deleted the build-test branch November 16, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwonoj @jridgewell