feat(tasks-fs): bump up notify, fix empty file watch #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
|
✅ This change can build |
kwonoj
force-pushed
the
bump-notify
branch
2 times, most recently
from
46cd943 to
34b9959
Compare
kwonoj
commented
Feb 10, 2024
kwonoj
changed the title
|
Testing against next.js seems passing at least vercel/next.js#61879 |
kwonoj
commented
Feb 10, 2024
kwonoj
commented
Feb 10, 2024
sokra
reviewed
Feb 10, 2024
sokra
reviewed
Feb 10, 2024
| .insert(PathBuf::from(&root)); | ||
| batched_invalidate_path_and_children_dir | ||
| .insert(PathBuf::from(&root)); | ||
| Ok(Ok(events)) => { |
There was a problem hiding this comment.
would be nice to split this whole thing out into a new file like I had done in #2936
There was a problem hiding this comment.
yeah, would like to do a followup pr. moving whole makes diff bit unfriendly in gh for the review esp this contains some event type changes for the subscription.
There was a problem hiding this comment.
idk, you already have to manually compare as the diff doesn't line up at all
There was a problem hiding this comment.
yeah but it's still diff. for this change, unless it is explicitly required I'd like to make minimal.
crates/turbo-tasks-fs/src/lib.rs
Outdated
| @@ -264,6 +270,26 @@ impl DiskFileSystem { | |||
| self.start_watching_internal(true) | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
use a doc comment for this
sokra
approved these changes
Feb 12, 2024
Comment on lines
+319
to
+320
| debounced_watcher | ||
| .watcher() | ||
| .watch(&root_path, RecursiveMode::Recursive)?; |
There was a problem hiding this comment.
I think we also want the "cache" here and below?
debouncer.cache().add_root(&root_path, RecursiveMode::Recursive);
There was a problem hiding this comment.
full debouncer internally autosetup those
There was a problem hiding this comment.
but the version in this PR is too old
kwonoj
added a commit
to vercel/next.js
that referenced
this pull request
Feb 12, 2024
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> ### What * vercel/turborepo#7340 <!-- OJ Kwon - feat(tasks-fs): bump up notify, fix empty file watch --> Bump up turbopack PR to fix hmr issues. Closes PACK-2466
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…o#7340) ### Description This PR upgrades `notify` pkg to create a filesystem watcher. It is due to recent issue we found in PACK-2437, the edge cases like - start a watcher with file have any contents - open editor, clear all (make file empty), save doesn't create any file watcher event. This makes some cases turbopack does not trigger hmr even if it's desired. One thing to note is even with upgrade its event kind is somewhat unexpected; it's not `Modify` event but `Metadata` event. I can't say why it emits in that way, but add it as workaround for now. We had experiences of trying to upgrade & revert this pkg before, so the upgrade plan need some caution. Plan is - Once PR is approved, cut turbopack _before_ PR and bump next.js first - Land PR, create new turbopack release so release contains only 1 changes to notify - Ensure new turbopack update in next.js won't break (like upgrading front, etcs) and make it easy to revert Closes PACK-2437.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…o#7340) ### Description This PR upgrades `notify` pkg to create a filesystem watcher. It is due to recent issue we found in PACK-2437, the edge cases like - start a watcher with file have any contents - open editor, clear all (make file empty), save doesn't create any file watcher event. This makes some cases turbopack does not trigger hmr even if it's desired. One thing to note is even with upgrade its event kind is somewhat unexpected; it's not `Modify` event but `Metadata` event. I can't say why it emits in that way, but add it as workaround for now. We had experiences of trying to upgrade & revert this pkg before, so the upgrade plan need some caution. Plan is - Once PR is approved, cut turbopack _before_ PR and bump next.js first - Land PR, create new turbopack release so release contains only 1 changes to notify - Ensure new turbopack update in next.js won't break (like upgrading front, etcs) and make it easy to revert Closes PACK-2437.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…o#7340) ### Description This PR upgrades `notify` pkg to create a filesystem watcher. It is due to recent issue we found in PACK-2437, the edge cases like - start a watcher with file have any contents - open editor, clear all (make file empty), save doesn't create any file watcher event. This makes some cases turbopack does not trigger hmr even if it's desired. One thing to note is even with upgrade its event kind is somewhat unexpected; it's not `Modify` event but `Metadata` event. I can't say why it emits in that way, but add it as workaround for now. We had experiences of trying to upgrade & revert this pkg before, so the upgrade plan need some caution. Plan is - Once PR is approved, cut turbopack _before_ PR and bump next.js first - Land PR, create new turbopack release so release contains only 1 changes to notify - Ensure new turbopack update in next.js won't break (like upgrading front, etcs) and make it easy to revert Closes PACK-2437.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…o#7340) ### Description This PR upgrades `notify` pkg to create a filesystem watcher. It is due to recent issue we found in PACK-2437, the edge cases like - start a watcher with file have any contents - open editor, clear all (make file empty), save doesn't create any file watcher event. This makes some cases turbopack does not trigger hmr even if it's desired. One thing to note is even with upgrade its event kind is somewhat unexpected; it's not `Modify` event but `Metadata` event. I can't say why it emits in that way, but add it as workaround for now. We had experiences of trying to upgrade & revert this pkg before, so the upgrade plan need some caution. Plan is - Once PR is approved, cut turbopack _before_ PR and bump next.js first - Land PR, create new turbopack release so release contains only 1 changes to notify - Ensure new turbopack update in next.js won't break (like upgrading front, etcs) and make it easy to revert Closes PACK-2437.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades
notifypkg to create a filesystem watcher.It is due to recent issue we found in PACK-2437, the edge cases like
doesn't create any file watcher event. This makes some cases turbopack does not trigger hmr even if it's desired.
One thing to note is even with upgrade its event kind is somewhat unexpected; it's not
Modifyevent butMetadataevent. I can't say why it emits in that way, but add it as workaround for now.We had experiences of trying to upgrade & revert this pkg before, so the upgrade plan need some caution.
Plan is
Closes PACK-2437.