feat: --only now applies to package dependencies #8163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
mehulkar
approved these changes
May 17, 2024
| .collect(), | ||
| ) | ||
| } else { | ||
| None |
There was a problem hiding this comment.
Why is this none? shouldn't it be all?
There was a problem hiding this comment.
never mind, I saw the rest of the code and saw how allowed_tasks is used. the name of the method just threw me off
chris-olszewski
deleted the
chrisolszewski/turbo-2705-change-only-behavior
branch
chris-olszewski
added a commit
that referenced
this pull request
May 20, 2024
### Description
Change `--only` so it behaves in a more sensible way. It still shouldn't
be widely used, but now it at least does what it says it does.
Previously `--only` would still follow package dependencies resulting
additional tasks getting run that weren't expected.
e.g. for task definition `"test": {"dependsOn": ["build", "^test"]}` and
package `a` depending on `b`, then `turbo test --filter=a --only` would
result in both `a#test` and `b#test` being run. With this PR now only
`a#test` will be run.
I changed the `--only` logic so now it will limit tasks in the graph to
exactly those that are in the product of the packages implied by
`--filter` and the tasks specified in the run args. This should make
`--only` a far more sensible flag.
### Testing Instructions
Added unit tests for testing the trimming of package dependencies and
task id style dependencies e.g. `"dependsOn": ["a#test"]`
chris-olszewski
added a commit
that referenced
this pull request
May 22, 2024
### Description
Change `--only` so it behaves in a more sensible way. It still shouldn't
be widely used, but now it at least does what it says it does.
Previously `--only` would still follow package dependencies resulting
additional tasks getting run that weren't expected.
e.g. for task definition `"test": {"dependsOn": ["build", "^test"]}` and
package `a` depending on `b`, then `turbo test --filter=a --only` would
result in both `a#test` and `b#test` being run. With this PR now only
`a#test` will be run.
I changed the `--only` logic so now it will limit tasks in the graph to
exactly those that are in the product of the packages implied by
`--filter` and the tasks specified in the run args. This should make
`--only` a far more sensible flag.
### Testing Instructions
Added unit tests for testing the trimming of package dependencies and
task id style dependencies e.g. `"dependsOn": ["a#test"]`
chris-olszewski
added a commit
that referenced
this pull request
May 28, 2024
### Description
Change `--only` so it behaves in a more sensible way. It still shouldn't
be widely used, but now it at least does what it says it does.
Previously `--only` would still follow package dependencies resulting
additional tasks getting run that weren't expected.
e.g. for task definition `"test": {"dependsOn": ["build", "^test"]}` and
package `a` depending on `b`, then `turbo test --filter=a --only` would
result in both `a#test` and `b#test` being run. With this PR now only
`a#test` will be run.
I changed the `--only` logic so now it will limit tasks in the graph to
exactly those that are in the product of the packages implied by
`--filter` and the tasks specified in the run args. This should make
`--only` a far more sensible flag.
### Testing Instructions
Added unit tests for testing the trimming of package dependencies and
task id style dependencies e.g. `"dependsOn": ["a#test"]`
chris-olszewski
added a commit
that referenced
this pull request
May 29, 2024
### Description
Change `--only` so it behaves in a more sensible way. It still shouldn't
be widely used, but now it at least does what it says it does.
Previously `--only` would still follow package dependencies resulting
additional tasks getting run that weren't expected.
e.g. for task definition `"test": {"dependsOn": ["build", "^test"]}` and
package `a` depending on `b`, then `turbo test --filter=a --only` would
result in both `a#test` and `b#test` being run. With this PR now only
`a#test` will be run.
I changed the `--only` logic so now it will limit tasks in the graph to
exactly those that are in the product of the packages implied by
`--filter` and the tasks specified in the run args. This should make
`--only` a far more sensible flag.
### Testing Instructions
Added unit tests for testing the trimming of package dependencies and
task id style dependencies e.g. `"dependsOn": ["a#test"]`
chris-olszewski
added a commit
that referenced
this pull request
May 31, 2024
### Description
Change `--only` so it behaves in a more sensible way. It still shouldn't
be widely used, but now it at least does what it says it does.
Previously `--only` would still follow package dependencies resulting
additional tasks getting run that weren't expected.
e.g. for task definition `"test": {"dependsOn": ["build", "^test"]}` and
package `a` depending on `b`, then `turbo test --filter=a --only` would
result in both `a#test` and `b#test` being run. With this PR now only
`a#test` will be run.
I changed the `--only` logic so now it will limit tasks in the graph to
exactly those that are in the product of the packages implied by
`--filter` and the tasks specified in the run args. This should make
`--only` a far more sensible flag.
### Testing Instructions
Added unit tests for testing the trimming of package dependencies and
task id style dependencies e.g. `"dependsOn": ["a#test"]`
chris-olszewski
added a commit
that referenced
this pull request
Jun 4, 2024
### Description
Change `--only` so it behaves in a more sensible way. It still shouldn't
be widely used, but now it at least does what it says it does.
Previously `--only` would still follow package dependencies resulting
additional tasks getting run that weren't expected.
e.g. for task definition `"test": {"dependsOn": ["build", "^test"]}` and
package `a` depending on `b`, then `turbo test --filter=a --only` would
result in both `a#test` and `b#test` being run. With this PR now only
`a#test` will be run.
I changed the `--only` logic so now it will limit tasks in the graph to
exactly those that are in the product of the packages implied by
`--filter` and the tasks specified in the run args. This should make
`--only` a far more sensible flag.
### Testing Instructions
Added unit tests for testing the trimming of package dependencies and
task id style dependencies e.g. `"dependsOn": ["a#test"]`
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
--onlyso it behaves in a more sensible way. It still shouldn't be widely used, but now it at least does what it says it does.Previously
--onlywould still follow package dependencies resulting additional tasks getting run that weren't expected.e.g. for task definition
"test": {"dependsOn": ["build", "^test"]}and packageadepending onb, thenturbo test --filter=a --onlywould result in botha#testandb#testbeing run. With this PR now onlya#testwill be run.I changed the
--onlylogic so now it will limit tasks in the graph to exactly those that are in the product of the packages implied by--filterand the tasks specified in the run args. This should make--onlya far more sensible flag.Testing Instructions
Added unit tests for testing the trimming of package dependencies and task id style dependencies e.g.
"dependsOn": ["a#test"]