Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turbo-ignore): packages can be undefined #8171

Closed

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented May 17, 2024

On monorepo: false, there is no packages value which will throw when packages.length.

Screenshot 2024-05-18 at 1 42 38 AM

@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo pkg: turbo-ignore packages/turbo-ignore labels May 17, 2024
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 17, 2024 4:06pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 4:06pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 4:06pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 4:06pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 4:06pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 4:06pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 4:06pm

Copy link

vercel bot commented May 17, 2024

@devjiwonchoi is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented May 17, 2024

Allow CI Workflow Run

  • approve CI run for commit: 3b722e8

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@devjiwonchoi devjiwonchoi changed the title fix: pacakges can be undefined fix(turbo-ignore): packages can be undefined May 17, 2024
@devjiwonchoi devjiwonchoi marked this pull request as ready for review May 17, 2024 16:20
@devjiwonchoi devjiwonchoi requested a review from a team as a code owner May 17, 2024 16:20
@devjiwonchoi devjiwonchoi marked this pull request as draft May 17, 2024 16:21
@devjiwonchoi
Copy link
Member Author

Seems like it needs modification on turborepo, moving to issue #8172

@devjiwonchoi devjiwonchoi deleted the fix/turbo-ignore-monorepo-false branch May 17, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage pkg: turbo-ignore packages/turbo-ignore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants