Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs) Consistency for configurations between docs and examples. #9212

Merged
merged 1 commit into from
Oct 3, 2024
Merged

(docs) Consistency for configurations between docs and examples. #9212

merged 1 commit into from
Oct 3, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Oct 3, 2024 •
edited
Loading

Description

@boutchitos astutely pointed out in #9191 that we had some inconsistencies between create-turbo, the TypeScript doc, and with-vite. This PR fixes those issues.

@anthonyshew anthonyshew requested a review from a team as a code owner October 3, 2024 04:51
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation area: examples Improvements or additions to examples created-by: turborepo labels Oct 3, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 4:52am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 4:52am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 4:52am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 4:52am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 4:52am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 4:52am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 4:52am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 4:52am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 4:52am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hi there 👋

It looks like this PR introduces broken links to the docs, please take a moment to fix them before merging:

Broken link Type File
/repo/docs/guides/tools/typescript#you-likely-dont-need-a-tsconfigjson-file-in-the-root-of-your-project hash /repo-docs/crafting-your-repository/structuring-a-repository.mdx
#package-entrypoint-wildcards hash /repo-docs/guides/tools/typescript.mdx
#package-entrypoint-wildcards hash /repo-docs/guides/tools/typescript.mdx

Thank you 🙏

@anthonyshew anthonyshew linked an issue Oct 3, 2024 that may be closed by this pull request
Inconsistency between create-turbo examples in regard of generated config files #9191
Closed
1 task
@anthonyshew anthonyshew merged commit ce11d86 into main Oct 3, 2024
35 of 37 checks passed
@anthonyshew anthonyshew deleted the shew-5710d branch October 3, 2024 04:57
@boutchitos
Copy link
Contributor

Awesome!

@Lavish1999 Lavish1999 mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: docs Improvements or additions to documentation area: examples Improvements or additions to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency between create-turbo examples in regard of generated config files
2 participants
@anthonyshew @boutchitos