fix: use oxc-resolver hot fix for symlinks #9302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
approved these changes
Oct 21, 2024
| @@ -147,11 +154,21 @@ impl File { | |||
| Ok(self.path.to_string()) | |||
| } | |||
|
|
|||
| async fn dependencies(&self, depth: Option<usize>) -> TraceResult { | |||
| async fn dependencies(&self, depth: Option<usize>, ts_config: Option<String>) -> TraceResult { | |||
There was a problem hiding this comment.
I think this is a behavior change where we now respect tsconfig? Maybe update PR description to include functionality this gains us? (I'm curious and want to know, but can't grok it from this PR)
There was a problem hiding this comment.
yeah tsconfig is necessary for doing prefix resolution, i.e. @/components/ui. tsconfig loading is what's broken in oxc-resolver
|
I'll make a release today. |
NicholasLYang
force-pushed
the
nicholasyang/oxc-resolver-fix
branch
from
85e18b9
to
adf8fad
Compare
- Renamed test -> test-data - Added query test - Fixed up setup_package_manager.sh to work with non-prysk tests
NicholasLYang
added a commit
that referenced
this pull request
Oct 22, 2024
### Description #9302 merged a little too early, so reverting some of the changes. Namely, we don't need the `test` -> `test-data` renaming anymore ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a bug in oxc-resolver for symlinks that basically breaks tsconfig resolution with pnpm (in a specific scenario for extending a tsconfig that's a workspace dependency). Until that's fixed, this PR switches us to a fork that has a very dumb hot fix
We also add tsconfig loading, either via a parameter or via walking up the path hierarchy for the closest tsconfig
Testing Instructions
Added a test based off of my repro. Validated that doesn't work with main branch of oxc-resolver, but does work on my fork