chore(visitor): break up visitor to multiple modules #9306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
approved these changes
Oct 22, 2024
tknickman
approved these changes
Oct 22, 2024
dimitropoulos
approved these changes
Oct 22, 2024
chris-olszewski
added a commit
that referenced
this pull request
Oct 30, 2024
### Description In #9306 I somehow dropped the `cmd.open_stdin()` call so we never started tasks hooked up to stdin. I verified I copied the closing/forwarding stdin logic in my refactor [as seen here](https://github.com/vercel/turborepo/blob/main/crates/turborepo-lib/src/task_graph/visitor/exec.rs#L376), we were just never opening it in the first place. ### Testing Instructions `turbo_dev dev` should now let you interact with `persistent` tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a prefactor to break up
visitor.rsinto multiple files. This is primarily just moving code around, but there are a few more in depth changes:TaskWarningto only be constructed if there are missing envs, removing the need to check later onwhichfor every task to find the package manager binary. We instead call this on construction, but will only handle the error case on actual command creation.I highly recommend reviewing each commit on it's own. All commits that move code do only that so hopefully that makes it easier to review.
Testing Instructions
Integration tests and some basic manual testing.