fix(watch): stopping persistent tasks #9330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
approved these changes
Oct 24, 2024
crates/turborepo-lib/src/run/mod.rs
Outdated
| @@ -137,7 +137,12 @@ impl Run { | |||
| } | |||
|
|
|||
| pub fn create_run_for_non_interruptible_tasks(&self) -> Self { | |||
| let mut new_run = self.clone(); | |||
| let mut new_run = Self { | |||
| // ProcessManager is a singleton, so we want to explicitly recreate it | |||
There was a problem hiding this comment.
Non blocking, but I think singleton is the wrong term as that means that only one of these should be created per thread. I think just saying the cloning a ProcessManager shares state is clear enough.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were accidentally stopping persistent tasks when we shouldn't have because we were reusing the same stopper.
Testing Instructions
We need a way to test persistent stuff and also run construction stuff.