Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (react-native-web-example): add tui to turbo config #9334

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix (react-native-web-example): add tui to turbo config #9334

merged 2 commits into from
Nov 12, 2024
+1 −0

Conversation

mcnaveen
Copy link
Contributor

Description

  • Adding ui to the turbo.json allows to have interactive tasks

#1235 (comment)

Testing Instructions

  1. Create a new project npx create-turbo@latest -e with-react-native-web
  2. Run pnpm run dev
  3. It opens a new terminal UI

@mcnaveen mcnaveen requested a review from a team as a code owner October 25, 2024 07:31
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Oct 25, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:17pm

@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024

@mcnaveen is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@mcnaveen mcnaveen changed the title fix (turbo): add tui to turbo config fix (react-native-web-example): add tui to turbo config Oct 25, 2024
@ijjk
Copy link
Member

ijjk commented Nov 12, 2024 •
edited by anthonyshew
Loading

Allow CI Workflow Run

  • approve CI run for commit: 8ee472e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 12, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8ee472e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

anthonyshew
anthonyshew approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! Thank you!

@anthonyshew anthonyshew enabled auto-merge (squash) November 12, 2024 18:18
@anthonyshew anthonyshew merged commit 904338b into vercel:main Nov 12, 2024
34 checks passed
This was referenced Nov 14, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcnaveen @ijjk @anthonyshew