chore: bump dependencies for Windows ARM support #9343
Merged
+174
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
commented
Oct 28, 2024
| @@ -101,7 +97,7 @@ console-subscriber = "0.1.8" | |||
| crossbeam-channel = "0.5.8" | |||
| dashmap = "5.4.0" | |||
| derive_setters = "0.1.6" | |||
| dialoguer = "0.10.3" | |||
| dialoguer = "0.11.0" | |||
There was a problem hiding this comment.
required to keep compatible dependencies between reqwest and dialoguer
chris-olszewski
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unfortunately this does not get us to build Windows ARM natively, but it at least eliminates the first blocker, which is ring 0.16. ring is a crypto library that
rustlsuses under the hood, and because it relies on inline assembly, it can't be built for Windows ARM. However, ring 0.17 added Windows ARM support. To get all our deps into ring 0.17, we need to bump reqwest and ureq. The first one is easy, but the second one is used by update-informer, so this PR redirects to my fork of update-informer that has a bumped ureq version.Testing Instructions
Try building on Windows ARM and validate that we "only" get an error for building tokio