Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace): add export conditions import and require to trace resolver #9360

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

NicholasLYang
Copy link
Contributor

Description

package.json exports can be selected based on conditions such as whether the package is being imported as an esm import or a require. We added import and require as default conditions for the resolver so packages that define these conditions trace properly.

Testing Instructions

Added a test with swr which uses these package export conditions

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:47pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Oct 31, 2024 7:47pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 31, 2024 7:47pm
examples-gatsby-web ⬜️ Ignored (Inspect) Oct 31, 2024 7:47pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Oct 31, 2024 7:47pm
examples-native-web ⬜️ Ignored (Inspect) Oct 31, 2024 7:47pm
examples-svelte-web ⬜️ Ignored (Inspect) Oct 31, 2024 7:47pm
examples-tailwind-web ⬜️ Ignored (Inspect) Oct 31, 2024 7:47pm
examples-vite-web ⬜️ Ignored (Inspect) Oct 31, 2024 7:47pm

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment +1 658 kB vercel-release-bot

View full report↗︎

@NicholasLYang NicholasLYang merged commit 2121ba9 into main Nov 1, 2024
40 checks passed
@NicholasLYang NicholasLYang deleted the nicholasyang/add-conditions-to-trace branch November 1, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants