feat(trace): pretty print trace errors to logs #9367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
NicholasLYang
force-pushed
the
nicholasyang/refine-tracing-errors
branch
from
5106592
to
53b2478
Compare
chris-olszewski
approved these changes
Nov 1, 2024
| } | ||
|
|
||
| impl TraceResult { | ||
| pub fn emit_errors(&self) { |
There was a problem hiding this comment.
So do proc macros mess up unused code detection? Could you add a decl to silence that warning?
There was a problem hiding this comment.
I think it's actually the combination binary/library crate that's causing this. Because from the binary's perspective this is unused
| @@ -80,7 +80,8 @@ pub async fn run( | |||
| // If the arg starts with "query" or "mutation", and ends in a bracket, it's | |||
| // likely a direct query If it doesn't, it's a file path, so we need to | |||
| // read it | |||
| let query = if (trimmed_query.starts_with("query") || trimmed_query.starts_with("mutation")) | |||
| let query = if (trimmed_query.starts_with("query") | |||
| || trimmed_query.starts_with("mutation") | trimmed_query.starts_with('{')) | |||
There was a problem hiding this comment.
I'm surprised there isn't an warning for using bitor
Suggested change
| || trimmed_query.starts_with("mutation") | trimmed_query.starts_with('{')) | |
| || trimmed_query.starts_with("mutation") || trimmed_query.starts_with('{')) |
NicholasLYang
force-pushed
the
nicholasyang/refine-tracing-errors
branch
from
9857197
to
7e7fc15
Compare
NicholasLYang
force-pushed
the
nicholasyang/refine-tracing-errors
branch
from
7e7fc15
to
ca839d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To help debug trace, pretty print the errors to stderr by default. Includes fancy error messages either via SWC or our own miette infrastructure
Testing Instructions
Try using trace and hit an error