chore(daemon): lazy load package changes watcher #9396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
chris-olszewski
approved these changes
Nov 6, 2024
|
|
||
| pub fn get_or_init_package_changes_watcher(&self) -> Arc<PackageChangesWatcher> { | ||
| self.package_changes_watcher | ||
| .get_or_init(|| { |
There was a problem hiding this comment.
So happy that OnceLock got stabilized
NicholasLYang
deleted the
nicholasyang/lazy-load-package-changes-watcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we'd initialize the package changes watcher when the daemon starts up. Now we do it only when watch mode needs it.
Testing Instructions
Tested manually:
In different terminal:
Change a file in the repository, note that no logs are emitted for this change.
Then run
Note that package changes start showing up.