Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update TypeScript wildcard recommendations #9983

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Feb 16, 2025

Description

@thdxr kindly pointed out that the wildcard recommendations in our docs weren't matching what he was seeing in his editor. I investigated and am similarly seeing that wildcard recommendations work as one would hope. The last time that I tried this, there was some limit at 10 exports paths or 10 variable exports (my memory is fuzzy). But that appears to be removed now in latest versions of TypeScript with modern settings (which is what the Turborepo docs on other tools always assume).

Additional credit to @baptisteArno who also was pointing this out to me in #9827. I'm going to use this PR since it has a few more spots in docs where things are updated, and has additional updates to our examples. But let the record show that @baptisteArno deserves credits here!

Testing

I hand-tested this in my editor and here's what I see. One or more of these didn't used to work but now it does.

CleanShot 2025-02-15 at 23 32 38@2x

Additionally, here is my editor recommending 10+ entrypoints.
CleanShot 2025-02-15 at 23 35 19@2x

@anthonyshew anthonyshew requested a review from a team as a code owner February 16, 2025 06:29
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation area: examples Improvements or additions to examples labels Feb 16, 2025
Copy link

vercel bot commented Feb 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 6:30am

@anthonyshew anthonyshew merged commit 3dfb1d3 into main Feb 18, 2025
38 checks passed
@anthonyshew anthonyshew deleted the shew/4c6d1 branch February 18, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Improvements or additions to documentation area: examples Improvements or additions to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants