Avoid abseil containers with SeqManager compare functions #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1366 ### Details - As demonstrated in temporal PR #1368, standard C++ STD containers do not throw (even in debug mode) when using `Compare` functions in maps/sets that do not honor transitivity, i.e. `comp(a,b) && comp(b,c) -> comp(a,c)`. - So let's not use abseil containers in those cases. ### Bonus tracks - Dupicate CI actions in debug mode. - Make mediasoup Rust building honor `MEDIASOUP_BUILDTYPE` env variable if given. - Fix an amazing bug in `AudioLevelObserver.cpp` which failed to compile because it uses a `absl::btree_multimap` without including the `absl/container/btree_map.h` header (it didn't fail before due to some absl header included by yet anothe included file, etc).
This was referenced Apr 9, 2024
ibc
changed the title
|
UPDATE: Fixed here: 3b23846 OMG... https://github.com/versatica/mediasoup/actions/runs/8613704210/job/23605569292?pr=1369 I'm reproducing it in local:
console.info console.error console.error |
|
UPDATE: Fixed here: 3b23846 Ok, here the coredump: It is in WebRtcServer::~WebRtcServer()
{
MS_TRACE();
MS_DUMP_STD("------ 1");
this->shared->channelMessageRegistrator->UnregisterHandler(this->id);
MS_DUMP_STD("------ 2");
for (auto& item : this->udpSocketOrTcpServers)
{
delete item.udpSocket;
item.udpSocket = nullptr;
delete item.tcpServer;
item.tcpServer = nullptr;
}
this->udpSocketOrTcpServers.clear();
MS_DUMP_STD("------ 3");
for (auto* webRtcTransport : this->webRtcTransports)
{
MS_DUMP_STD("------ 3.1");
webRtcTransport->ListenServerClosed();
MS_DUMP_STD("------ 3.2");
}
MS_DUMP_STD("------ 4");
this->webRtcTransports.clear();
MS_DUMP_STD("------ 5");
} |
|
UPDATE: Fixed here: 3b23846 Ok, I've added more logs and I see what it's happening:
|
|
I've fixed the bug here: 3b23846 |
jmillan
approved these changes
Apr 9, 2024
nazar-pc
reviewed
Feb 2, 2025
Comment on lines
+52
to
+57
| # NOTE: In Windows this will build and test libmediasoupworker in release | ||
| # mode twice since build.rs doesn't allow debug mode for Windows. | ||
| - name: cargo test | ||
| run: cargo test --verbose | ||
| run: | | ||
| cargo test --verbose | ||
| cargo test --release --verbose |
There was a problem hiding this comment.
What do you mean? cargo test is debug build, how is building it twice helps?
There was a problem hiding this comment.
Do you mean that I wrote this?
There was a problem hiding this comment.
I have absolutely no idea why that duplicate call was added
There was a problem hiding this comment.
Ah, it just tests debug and release builds, but internal C++ library is only compiled in release mode. Now I get it.
There was a problem hiding this comment.
And is it ok or does it make sense? I don't remember anything about this.
There was a problem hiding this comment.
Yes, all good, sorry for the noise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1366
Details
Comparefunctions in maps/sets that do not honor transitivity, i.e.comp(a,b) && comp(b,c) -> comp(a,c).Bonus tracks
AudioLevelObserver.cppwhich failed to compile because it uses aabsl::btree_multimapwithout including theabsl/container/btree_map.hheader (it didn't fail before due to some absl header included by yet anothe included file, etc).