Add dependency-descriptor support #1481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really appreciate this effort but definitely we don't want to depend on libwebrtc for things purely related to RTP parsing. In mediasoup we do RTP parsing from scratch, and that includes everything related to RTP header extensions and codec payloads. Another reason is that we want to get rid of libwebrtc (once we have our own BWE code). Said that, I will create a ticket to do this and reference this PR as documentation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dependency-descriptor extension support. Tested on mediasoup-demo.
Note: Now mediasoup-client can't get dd extension showup by default , so I have hardcode for testing. See :https://github.com/Lynnworld/mediasoup-client/blob/5e8ff720bfae116e62989eae984ad3ccf2b11cd9/src/handlers/ortc/utils.ts#L25