initial-work1:Implement JSONRPC as a wire protocol #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmlopes I am still working on this. I have pushed with some build failures though. I hope to rectify them on Sunday. I have created integrated tests by adding builds, dependencies, plugins and resources to the pom.xml file, adding a json file and a Rest integration test class. I hope to continue from where i have stopped. I however need more guidance on this. |
|
@pmlopes I am trying my best to understand the project requirements and as if i am lost in the middle of no where. I need more support on this. Could you kindly take me through the project requirements so that i can better understand? |
|
Removed the Rest test class, the additional dependencies to the pom.xm and the json file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Identify the right mapping between vertx messages and Json protocol given what the event bus does.
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
@pmlopes
I have created an EventBusClient which will help to connect the event bus to the EventBusBridge. Kindly review and advise me accordingly.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines