dns.py docstrings, RO props #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
therealsilence
commented
Sep 4, 2017
therealsilence
commented
- Format tweaks for readability
- Revise / add docstrings to forms and props
- Add read only ( 'ro' ) to properties that should not be modified once created
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 90.45% 90.47% +0.02%
==========================================
Files 127 127
Lines 14369 14373 +4
==========================================
+ Hits 12997 13004 +7
+ Misses 1372 1369 -3
Continue to review full report at Codecov.
|
invisig0th
previously approved these changes
Sep 8, 2017
| ('inet:dns:aaaa', {'subof': 'sepr', 'sep': '/', 'fields': 'fqdn,inet:fqdn|ipv6,inet:ipv6', | ||
| 'ex': 'vertex.link/2607:f8b0:4004:809::200e', | ||
| 'doc': 'The result of a DNS AAAA record lookup'}), | ||
| ('inet:dns:look', { |
There was a problem hiding this comment.
digging the readability breakdowns
- Format for readability - Revise / add docstrings to forms and form props - Add read only ( 'ro' ) to properties that should not be modified once created
…fter the original nodes have been created. This addresses an issue where the autoadd'd events may have required props which are not included in autoadds.
vEpiphyte
force-pushed
the
thesilence_dns
branch
from
29765be to
beacb99
Compare
vertexmc
reviewed
Sep 12, 2017
| ('ns:zone', {'ptype': 'inet:fqdn', 'ro': 1}), | ||
| ('ns', {'ptype': 'inet:dns:ns', 'doc': 'The DNS NS record returned by the lookup', 'ro': 1}), | ||
| ('ns:zone', {'ptype': 'inet:fqdn', 'doc': 'The domain queried for its DNS NS record', 'ro': 1}), | ||
| ('ns:ns', {'ptype': 'inet:fqdn', 'doc': 'The domain returned in the DNS NS record', 'ro': 1}), |
There was a problem hiding this comment.
@therealsilence - should this be name server?
vertexmc
reviewed
Sep 12, 2017
| ('ns:ns', {'ptype': 'inet:fqdn', 'ro': 1}), | ||
| ('ns:zone', {'ptype': 'inet:fqdn', 'ro': 1}), | ||
| ('ns', {'ptype': 'inet:dns:ns', 'doc': 'The DNS NS record returned by the lookup', 'ro': 1}), | ||
| ('ns:zone', {'ptype': 'inet:fqdn', 'doc': 'The domain queried for its DNS NS record', 'ro': 1}), |
There was a problem hiding this comment.
@therealsilence - should this be name server?
vertexmc
reviewed
Sep 12, 2017
| @@ -1799,6 +1800,10 @@ def addTufoEvents(self, form, propss): | |||
| xact.fire('node:add', form=form, valu=valu, node=node) | |||
| xact.spliced('node:add', form=form, valu=valu, props=props) | |||
|
|
|||
| if self.autoadd: | |||
There was a problem hiding this comment.
@vEpiphyte - this "ro props" change looks good to me. If you want, we can merge this now as a separate PR.
vertexmc
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.