Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the content related to dashboard deployment #2086

Merged
merged 3 commits into from
May 12, 2023

Conversation

akihi99
Copy link
Contributor

@akihi99 akihi99 commented May 11, 2023

What is changed, added or deleted? (Required)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

cooper-lzy
cooper-lzy previously approved these changes May 11, 2023
Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes made in the patch seem fine. Below are some feedback and suggestions:

Patch 1/2:

The changes made in the Subject line and the commit message seem appropriate and describe the changes made in the file.
The change in port number from 9090 to 9091 in the table of port descriptions is the only significant change.
The changes made in step 5 in the instructions section seem appropriate.
Patch 2/2:

The changes made in the Subject line and the commit message seem appropriate and describe the changes made in the file.
The changes made in the steps 4, 5, and 6 in the instructions section are minor and don't seem to affect the functionality of the code.
General:

The document seems to have clear instructions and explanations.
The examples provided in the document are helpful.
The formatting of the document is consistent and readable.
However, some minor typos and inconsistencies were observed, such as "automatically" spelled as "aumatically" in the table, and indentation inconsistency in step 4. These can be corrected if desired.
Overall, the changes seem to be appropriate and in line with the commit messages. No significant bugs were observed.

@cooper-lzy cooper-lzy merged commit 7b6acab into vesoft-inc:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants