feat: update output graph #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizy
reviewed
Mar 11, 2022
| @@ -0,0 +1,29 @@ | |||
| const int2HexColor = (num) => `#${num.toString(16).padStart(6, '0')}`; | |||
| const rgb2Int = (r, g, b) => r * 255 * 255 + g * 255 + b; | |||
There was a problem hiding this comment.
"255" need to be "256" , this bug was fixed in explorer
hetao92
force-pushed
the
hetao-dev
branch
3 times, most recently
from
f0d16d6 to
3d93eae
Compare
huaxiabuluo
reviewed
Mar 15, 2022
| }; | ||
| useEffect(() => { | ||
| const close = e => { | ||
| const isMenu = e.path.find(each => each.className === 'context-menu'); |
There was a problem hiding this comment.
safari doesn't has e.path attribute
const isMenu = (() => {
let target = e.target;
while (target && target !== app) {
if (target.className === 'context-menu') {
return true;
}
target = target.parentElement;
}
return false;
})();
mod: code review mod: code review mod: code review
hetao92
added a commit
to hetao92/nebula-studio
that referenced
this pull request
Mar 31, 2022
mod: code review mod: code review mod: code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.