-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standalone version for nebula #3310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Very clean.
Codecov Report
@@ Coverage Diff @@
## master #3310 +/- ##
==========================================
+ Coverage 85.19% 85.20% +0.01%
==========================================
Files 1304 1305 +1
Lines 121308 121343 +35
==========================================
+ Hits 103352 103394 +42
+ Misses 17956 17949 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, wait for the performance report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you have talked about whether to merge the meta server.
What type of PR is this?
What does this PR do?
Add nebula standalone version, replace rpc with local function call.
Which issue(s)/PR(s) this PR relates to?
close #3160
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: