Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone version for nebula #3310

Merged
merged 16 commits into from
Dec 27, 2021
Merged

Add standalone version for nebula #3310

merged 16 commits into from
Dec 27, 2021

Conversation

SuperYoko
Copy link
Contributor

@SuperYoko SuperYoko commented Nov 12, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Add nebula standalone version, replace rpc with local function call.

Which issue(s)/PR(s) this PR relates to?

close #3160

Special notes for your reviewer, ex. impact of this fix, etc:

  • compile graphd&storaged into one process
  • repalce thrift rpc call with local function call

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@SuperYoko SuperYoko added do not review PR: not ready for the code review yet wip Solution: work in progress labels Nov 12, 2021
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Nov 12, 2021
@SuperYoko SuperYoko removed the do not review PR: not ready for the code review yet label Nov 18, 2021
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Very clean.

src/clients/storage/GraphStorageClient.h Outdated Show resolved Hide resolved
src/daemons/StandAloneDaemon.cpp Outdated Show resolved Hide resolved
src/daemons/StandAloneDaemon.cpp Outdated Show resolved Hide resolved
src/storage/GraphStorageLocalServer.cpp Show resolved Hide resolved
src/storage/GraphStorageLocalServer.cpp Outdated Show resolved Hide resolved
src/storage/GraphStorageLocalServer.cpp Outdated Show resolved Hide resolved
@SuperYoko SuperYoko added type/feature req Type: feature request ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels Nov 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #3310 (9354ff4) into master (99f1f7a) will increase coverage by 0.01%.
The diff coverage is 80.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3310      +/-   ##
==========================================
+ Coverage   85.19%   85.20%   +0.01%     
==========================================
  Files        1304     1305       +1     
  Lines      121308   121343      +35     
==========================================
+ Hits       103352   103394      +42     
+ Misses      17956    17949       -7     
Impacted Files Coverage Δ
src/clients/storage/InternalStorageClient.h 100.00% <ø> (ø)
src/clients/storage/StorageClientBase.h 65.57% <ø> (ø)
src/common/thrift/ThriftClientManager-inl.h 89.36% <ø> (+6.38%) ⬆️
src/graph/service/GraphFlags.cpp 100.00% <ø> (ø)
src/graph/validator/MutateValidator.h 100.00% <ø> (ø)
src/kvstore/Listener.cpp 74.05% <ø> (ø)
src/kvstore/plugins/elasticsearch/ESListener.cpp 0.00% <ø> (ø)
src/storage/mutate/AddEdgesProcessor.h 100.00% <ø> (ø)
src/storage/mutate/AddVerticesProcessor.h 100.00% <ø> (ø)
src/webservice/WebService.h 100.00% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2beee55...9354ff4. Read the comment docs.

src/webservice/WebService.h Show resolved Hide resolved
src/storage/GraphStorageLocalServer.cpp Outdated Show resolved Hide resolved
src/clients/storage/StorageClientBase.h Show resolved Hide resolved
@SuperYoko SuperYoko removed the ready-for-testing PR: ready for the CI test label Dec 2, 2021
@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Dec 17, 2021
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, wait for the performance report

Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~~

@SuperYoko SuperYoko requested a review from a team December 27, 2021 05:21
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you have talked about whether to merge the meta server.

@yixinglu yixinglu merged commit 4d05fb0 into vesoft-inc:master Dec 27, 2021
@yixinglu yixinglu mentioned this pull request Dec 27, 2021
7 tasks
@cooper-lzy cooper-lzy requested a review from abby-cyber January 5, 2022 03:31
@SuperYoko SuperYoko deleted the alex_single_process branch September 28, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready for review ready-for-testing PR: ready for the CI test type/feature req Type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single-process & single-replica graph + storage daemon
6 participants