Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put dataVersionKey on create space for storage #3817

Merged
merged 9 commits into from
Jan 26, 2022
Merged

put dataVersionKey on create space for storage #3817

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3ae5125
put dataVersionKey on create space for storage
cangfengzhs Jan 26, 2022
8e5edbc
Merge branch 'master' into put-data-version-key
cangfengzhs Jan 26, 2022
89dfd5b
Merge branch 'master' into put-data-version-key
cangfengzhs Jan 26, 2022
f183fa6
Merge branch 'master' of https://github.com/vesoft-inc/nebula into pu…
cangfengzhs Jan 26, 2022
20d94c1
address some comments
cangfengzhs Jan 26, 2022
ba0bb81
Merge branch 'put-data-version-key' of github.com:cangfengzhs/nebula …
cangfengzhs Jan 26, 2022
449d16f
Merge branch 'master' into put-data-version-key
critical27 Jan 26, 2022
dc08ac8
Merge branch 'master' into put-data-version-key
Sophie-Xie Jan 26, 2022
fd7d1a9
Merge branch 'master' into put-data-version-key
Sophie-Xie Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/kvstore/RocksEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,16 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
status = rocksdb::DB::Open(options, path, &db);
}
CHECK(status.ok()) << status.ToString();
if (!readonly && spaceId_ != 0 /* only for storage*/) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use kDefaultPartId

rocksdb::ReadOptions readOptions;
std::string dataVersionValue = "";
status = db->Get(readOptions, NebulaKeyUtils::dataVersionKey(), &dataVersionValue);
if (status.IsNotFound()) {
rocksdb::WriteOptions writeOptions;
status = db->Put(writeOptions, NebulaKeyUtils::dataVersionKey(), "3.0");
Copy link
Contributor

@pengweisong pengweisong Jan 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use NebulaKeyUtilsV3::dataVersionValue() to replace the literal value?

}
CHECK(status.ok()) << status.ToString();
}
db_.reset(db);
extractorLen_ = sizeof(PartitionID) + vIdLen;
partsNum_ = allParts().size();
Expand Down