Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support variable when seeking by property index in match clause #5553

Merged
merged 10 commits into from
May 18, 2023
Merged

Support variable when seeking by property index in match clause #5553

merged 10 commits into from
May 18, 2023

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented May 16, 2023 •
edited by Sophie-Xie
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#5509

Description:

How do you solve it?

Use argument plan node to reuse the ready results to build the index query context needed by lookup interface at runtime.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label May 16, 2023
jievince
jievince approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Sophie-Xie Sophie-Xie merged commit 979f602 into vesoft-inc:master May 18, 2023
@yixinglu yixinglu deleted the opt-didi-prop branch May 18, 2023 03:14
@wey-gu wey-gu mentioned this pull request May 20, 2023
Closed
yixinglu added a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
@Sophie-Xie @yixinglu
Support variable when seeking vertex id or property index in match (v…
5e27f2c 
…esoft-inc#2776)

* Support variable when seeking by id in match clause vesoft-inc#5486

* Support variable when seeking by property index in match clause (vesoft-inc#5553)

* Support variable when seeking by prop index in match clause

* Rename

* Move the index query context construction outside of OptRule

* Move the optimizer utils to common graph util folder

* Eval argument values in index scan executor

* Fix bug

* refactor and fix error

* Update tck tests

---------

Co-authored-by: Sophie <[email protected]>

* Resolve the conflicts

---------

Co-authored-by: Yee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

@nevermore3 nevermore3 nevermore3 approved these changes

@czpmango czpmango Awaiting requested review from czpmango

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yixinglu @nevermore3 @jievince @Sophie-Xie